-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains: Add make primary domain functionality to new site domains view #44135
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~341 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Add busy message which is shown when a domain is "busy", e.g. it is being set as primary.
f1bf539
to
64fb830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I took the liberty of updating the PR to enable the "Change primary domain" button in the primary domain header card.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4112146 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This adds the ability to set domains as primary in the new site domains view.
Testing instructions
Also, set
state.changePrimaryDomainModeEnabled
totrue
, and: