Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Add make primary domain functionality to new site domains view #44135

Merged
merged 8 commits into from
Jul 20, 2020

Conversation

eltongo
Copy link
Contributor

@eltongo eltongo commented Jul 14, 2020

Changes proposed in this Pull Request

This adds the ability to set domains as primary in the new site domains view.

Screenshot 2020-07-14 at 3 15 18 PM

Screenshot 2020-07-14 at 3 15 36 PM

Testing instructions

  • Go to /domains/manage/
  • Test 'Make primary domain' button works as expected

Also, set state.changePrimaryDomainModeEnabled to true, and:

  • Verify the radio button shows correctly
  • Verify on free sites, the plan upsell appears
  • Make sure choosing any domain makes that domain primary (when eligible)

@eltongo eltongo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jul 14, 2020
@eltongo eltongo requested a review from a team July 14, 2020 13:20
@eltongo eltongo self-assigned this Jul 14, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jul 14, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~341 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +2445 B  (+0.2%)     +341 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@hambai hambai force-pushed the add/primary-domain-new-design branch from f1bf539 to 64fb830 Compare July 17, 2020 11:19
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I took the liberty of updating the PR to enable the "Change primary domain" button in the primary domain header card.

@eltongo eltongo merged commit d06a583 into master Jul 20, 2020
@eltongo eltongo deleted the add/primary-domain-new-design branch July 20, 2020 10:21
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2020
@a8ci18n
Copy link

a8ci18n commented Jul 20, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4112146

Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 30, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants