Earn: do not register premium content blocks when gutenberg features are not available #44191
Conversation
gwwar
added
[Status] In Progress
[Status] Needs Review
| { /* eslint-disable-next-line wpcalypso/jsx-classname-namespace */ } | ||
| <Block.div className="wp-block-button"> | ||
| <RichText | ||
| placeholder={ __( 'Add text…', 'full-site-editing' ) } |
There was a problem hiding this comment.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 103 times:
translate( 'Add text…' ) ES Score: 9
|
Caution: This PR affects files in the FSE Plugin on WordPress.com D46452-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
So latest WP 5.4.2 has a mix of Gutenberg plugin versions of 6.6-7.5 https://developer.wordpress.org/block-editor/principles/versions-in-wordpress/ so I'm pretty sure provides context isn't available, meaning that decoupled buttons won't work. I believe this originally landed in WordPress/gutenberg#21467 (landed in 8.0) Chatting through some options with Kirk, when we detect that we don't have our required features available:
|
…tures are not available
gwwar
force-pushed
the
fix/premium-content-g-disabled
branch
from
54df03c
to
ffe1b0f
Compare
gwwar
changed the title
|
If the default block not registered message is too confusing we can add specific instructions, but we'll need to be careful to not be destructive on save.
|
gwwar
requested review from
fullofcaffeine,
a team and
deBhal
and removed request for
fullofcaffeine
|
Unrelated E2E failure for Gutenberg media upload looks like it's timing out on multiple branch runs. Manual testing looks okay so likely that test needs tuning. |
| const supportsDecoupledBlocks = !! ( | ||
| __experimentalAlignmentHookSettingsProvider && __experimentalBlock | ||
| ); |
There was a problem hiding this comment.
Thanks, I was starting to investigate experimental feature usage (#44251), I can tick these off.
|
Thanks for the review @sirreal! I'll go ahead and land this to unblock the next FSE release |
matticbot
removed
the
[Status] Needs Review
Fixes #44160 this PR simply opts to not register the premium content block when our desired gutenberg features are not available.
Previously in #42715 we added the ability to decouple the premium content buttons from the container block. This depended on the provides context block feature that landed in Gutenberg plugin ~8.0. Latest WP 5.4.2 has a mix of Gutenberg plugin versions of 6.6-7.5 https://developer.wordpress.org/block-editor/principles/versions-in-wordpress meaning that a fallback approach isn't viable in this case (we'd have to guess the passed planId).
Testing Instructions
FSE plugin / Build FSE plugin (pull_request)In this PR's GH workflow