Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new availability message #44466

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

delputnam
Copy link
Contributor

Changes proposed in this Pull Request

  • Update the error message shown when attempting purchase a mapping for a subdomain that has a pre-existing conflicting CNAME record.

Testing instructions

  • Apply D46527-code
  • Create a CNAME record for a domain that you own (ex. foo.example.com)
  • Attempt to purchase a mapping for the subdomain
  • Make sure that the correct error message is shown:

Screen_Shot_2020-07-17_at_1_34_09_PM

@delputnam delputnam self-assigned this Jul 27, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jul 27, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~35 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +52 B  (+0.0%)      +35 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~81 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +285 B  (+0.0%)      +81 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~74 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +285 B  (+0.1%)      +74 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@klimeryk klimeryk added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jul 27, 2020
@delputnam delputnam requested a review from a team July 27, 2020 16:56
Copy link
Contributor

@klimeryk klimeryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected. One small comment to fix before merging 🙇

args: { domain },
components: {
strong: <strong />,
a: <a rel="noopener noreferrer" href={ domainTransferIn( site, domain ) } />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this a component is a leftover from some delicious copypasta 😋

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

@klimeryk klimeryk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 27, 2020
@delputnam delputnam merged commit 8879878 into master Jul 27, 2020
@delputnam delputnam deleted the update/better-message-for-conflicting-subdomain branch July 27, 2020 19:52
@a8ci18n
Copy link

a8ci18n commented Jul 27, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4144822

Thank you @delputnam for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 7, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants