Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Offer Reset constants #44705

Merged
merged 4 commits into from Aug 6, 2020
Merged

Adds Offer Reset constants #44705

merged 4 commits into from Aug 6, 2020

Conversation

ChaosExAnima
Copy link
Contributor

@ChaosExAnima ChaosExAnima commented Aug 5, 2020

Changes proposed in this Pull Request

  • Adds Offer Reset constants and tests them with new plan picker.

Testing instructions

  • Verify constants and text matches copy document (see ticket below)

Fixes 1169247016322522-as-1187323761633610.

@ChaosExAnima ChaosExAnima added [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] In Progress labels Aug 5, 2020
@ChaosExAnima ChaosExAnima self-assigned this Aug 5, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Aug 5, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~675 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main      +3481 B  (+0.3%)     +675 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ChaosExAnima ChaosExAnima marked this pull request as ready for review August 5, 2020 19:45
@ChaosExAnima ChaosExAnima added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Aug 5, 2020
@ChaosExAnima ChaosExAnima requested a review from a team August 5, 2020 19:45
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChaosExAnima ChaosExAnima merged commit 8cdd64e into master Aug 6, 2020
@ChaosExAnima ChaosExAnima deleted the add/get-new-product-data branch August 6, 2020 14:51
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 6, 2020
@a8ci18n
Copy link

a8ci18n commented Aug 6, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4200777

Hi @ChaosExAnima, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Jetpack Security {{em}}Daily{{/em}}
  • Enjoy the peace of mind of complete site protection. Great for brochure sites, restaurants, blogs, and resume sites.
  • Best for sites with occasional updates
  • Jetpack Security {{em}}Real-time{{/em}}
  • Additional security for sites with 24/7 activity. Recommended for eCommerce stores, news organizations, and online forums.
  • Best for sites with frequent updates
  • Jetpack Complete
  • The most powerful WordPress sites: Top-tier security bundle, enhanced search
  • Complete WordPress security, performance, and growth

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Aug 13, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants