EditingToolkit > GlobalStyles: Add new Google fonts

[allilevine]

Changes proposed in this Pull Request

We've decided to offer additional Google fonts on WordPress.com. This PR adds those fonts to the Editing Toolkit > Global Styles > Font Selection options:

Testing instructions

To test this change on your sandbox you can apply the patch D47730-code and sandbox the public API, then test on your sandboxed site.

• Edit a page and click the "A" button in the upper right.
• The following fonts are available under "Font Selection" in both the Heading Font and Base Font select elements:
  Theme Default
  System Font
  Arvo
  Cabin
  Chivo
  Courier Prime
  Domine
  EB Garamond
  Fira Sans
  Josefin
  Libre Baskerville
  Libre Bodoni
  Libre Franklin
  Lora
  Merriweather
  Montserrat
  Nunito
  Open Sans
  Overpass
  Playfair Display
  Poppins
  Raleway
  Roboto
  Roboto Slab
  Rubik
  Source Sans Pro
  Source Serif Pro
  Space Mono
  Work Sans

Fixes https://github.com/Automattic/dotcom-manage/issues/111

[matticbot]

Test live: https://calypso.live/?branch=add/new-google-fonts

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D47730-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

[glendaviesnz]

This tested well for me ... happy to give it a green tick tomorrow once you decide what to do with that font ... I would be inclined to remove it for now and merge others, unless you can track down an alternative one quickly.

[allilevine]

This tested well for me ... happy to give it a green tick tomorrow once you decide what to do with that font ... I would be inclined to remove it for now and merge others, unless you can track down an alternative one quickly.

Thanks! I removed Libre Bodoni. I also corrected the name of "Josefin" to "Josefin Sans".

[glendaviesnz]

I rebased the branch to fix the build issues with the associated diff, and was then able to to sandbox and the new fonts appeared and could be applied.

[glendaviesnz]

given that this doesn't get merged into the calypso app you can probably ignore the e2e test failures

[simison]

Completely unrelated to this PR but shouldn't these be wrapped in translation functions?

wp-calypso/apps/full-site-editing/full-site-editing-plugin/global-styles/class-global-styles.php

Lines 84 to 91 in 493bac8

	const AVAILABLE_FONTS = array(
	array(
	'label' => 'Theme Default',
	'value' => 'unset',
	),
	array(
	'label' => 'System Font',
	'value' => self::SYSTEM_FONT,

wp-calypso/apps/full-site-editing/full-site-editing-plugin/global-styles/class-global-styles.php

Line 191 in 493bac8

'label' => 'System Font & Libre Baskerville',

wp-calypso/apps/full-site-editing/full-site-editing-plugin/global-styles/class-global-styles.php

Line 147 in 493bac8

'default' => 'Your site name',

[allilevine]

Completely unrelated to this PR but shouldn't these be wrapped in translation functions?

@simison Thanks for pointing that out! They should be. Can we open a new issue to add translation functions? I don't want to hold up the font updates.

[pablinos]

This is working for me too. I think we should get some help with deployment. I'm not sure we've got access to the .org repo for example.

Can we open a new issue to add translation functions?

Yes, let's do that as a separate PR. Let's open an issue so we don't forget.