Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update title of the plan details page #45073

Merged
merged 3 commits into from Aug 21, 2020
Merged

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Aug 20, 2020

Changes proposed in this Pull Request

  • Update the copy of the title in the plan/product details page
  • Add top margin to the title

Testing instructions

  • Visit the Plans section with the offer reset flow enabled
  • Click on the button of the Jetpack Security card, and check that you land in the details page
  • Check that the title mentions "Security"
  • Back to the Plans page, click on the Jetpack Backup card
  • In the details page, check that the title mentions "Backup"

Screenshots

Security
Screen Shot 2020-08-21 at 9 55 49 AM

Backup
Screen Shot 2020-08-21 at 9 55 41 AM

Mobile
Screen Shot 2020-08-21 at 9 59 17 AM

@monsieur-z monsieur-z added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. labels Aug 20, 2020
@matticbot
Copy link
Contributor

@monsieur-z monsieur-z marked this pull request as ready for review August 20, 2020 18:35
@monsieur-z monsieur-z requested a review from a team August 20, 2020 18:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2020
@matticbot
Copy link
Contributor

matticbot commented Aug 20, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~181 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
plans                 +319 B  (+0.1%)      +74 B  (+0.0%)
jetpack-connect       +319 B  (+0.0%)      +65 B  (+0.0%)
purchases             +187 B  (+0.0%)      +42 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z force-pushed the update/offer-reset-copy-tweaks branch from 0736c82 to 1f92fb1 Compare August 21, 2020 13:56
@monsieur-z monsieur-z requested a review from a team August 21, 2020 14:00
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

@monsieur-z monsieur-z merged commit 6b22688 into master Aug 21, 2020
@monsieur-z monsieur-z deleted the update/offer-reset-copy-tweaks branch August 21, 2020 14:19
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 21, 2020
@a8ci18n
Copy link

a8ci18n commented Aug 21, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4252529

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 31, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants