Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy of Security Real-time upgrade nudge #45081

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

monsieur-z
Copy link
Contributor

Changes proposed in this Pull Request

Updated the copy of the upgrade nudge for Security Real-time to match the copydeck

Testing instructions

  • Select a self-hosted Jetpack site with Security Daily purchased
  • Visit the Plans section with the offer reset flow enabled
  • See the nudge in the features section of Security Daily and check its copy

Screenshots

Updated nudge
Screen Shot 2020-08-20 at 5 04 38 PM

@monsieur-z monsieur-z added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. labels Aug 20, 2020
@monsieur-z monsieur-z requested a review from a team August 20, 2020 21:13
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 20, 2020
@monsieur-z
Copy link
Contributor Author

@rcanepa, I tried to not split apart from the current implementation, especially since as mentioned the copy might come from the API in the future.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~69 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
plans                 +236 B  (+0.0%)      +32 B  (+0.0%)
jetpack-connect       +236 B  (+0.0%)      +37 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@monsieur-z monsieur-z merged commit 30e15a8 into master Aug 21, 2020
@monsieur-z monsieur-z deleted the update/security-rt-upgrade-nudge-copy branch August 21, 2020 12:53
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 21, 2020
@a8ci18n
Copy link

a8ci18n commented Aug 21, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4251743

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 31, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants