New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium Content: Fix redirect behavior after connecting to Stripe #45204
Conversation
…to wpcom after connecting
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D48591-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some testing confusion over two seeing two Connect buttons, but I got this to work 🎉
What's the purpose of adding the extra commentary after |
@krymson24 All the changes in the first commit of this PR were to address issues that the linter had with the file (without which Husky wouldn't let the main commit go through). Some of these issues included missing JSDoc descriptions for params (the info after the |
Changes proposed in this Pull Request
Testing instructions
https://wordpress.com/posts/yoursite.wordpress.com
and click "Add New Post"wordpress.com/block-editor
.wp-admin
panel and create a new post from there.wp-admin/post.php
Verify that under the Edit view in the "Non-Subscriber View" section, the user is only presented with a single message indicating they should connect the account to Stripe.
Fixes #43222