Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Toolkit: Update the readme to include a "rename info" section #45212

Merged
merged 1 commit into from Aug 26, 2020

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Aug 26, 2020

See #45186 (comment)

With #44501 we renamed most of the FSE plugin to Editing Toolkit.
When merging, I've missed this readme mentioning the ongoing renaming process.

I'm aware that some of the "did not change" items are being worked on (e.g. #44552), but I think we can still say that the rename has been completed, as the phrasing in the readme is clear enough imho regarding what has and has not been done.

@Copons Copons added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 26, 2020
@Copons Copons requested a review from a team August 26, 2020 10:57
@Copons Copons self-assigned this Aug 26, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D48620-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@noahtallen noahtallen merged commit be6ddeb into master Aug 26, 2020
@noahtallen noahtallen deleted the update/editing-toolkit-readme branch August 26, 2020 18:07
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants