Editing toolkit: Update Newspack to 1.8.0 #45423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-jackson
added
the
Editing Toolkit
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
added
the
[Status] Needs Review
|
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D49166-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
david-szabo97
approved these changes
Sep 7, 2020
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This version includes the bug fix for Automattic/newspack-blocks#510. But we need to upgrade the version used on wpcom for our customers to get the fix too (tracked here #43049)
I've done the minimum version bump required to get the bug fix to play it safe, since I'm not very familiar with the recent changes in the blocks and how disruptive they'll be. But I could be convinced that this is the wrong approach.
Release notes for all the 1.7 to 1.8 changes:
Testing instructions
Fixes #43049