Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack Cloud Settings Host Credentials Status #45434

Merged
merged 12 commits into from Sep 7, 2020

Conversation

cbauerman
Copy link
Contributor

@cbauerman cbauerman commented Sep 7, 2020

Changes proposed in this Pull Request

Motivation: Add component for top status durning new host-specific credential flow

  • Add <ConnectionStatus /> component to new credentials settings page
  • A couple file org changes

Untitled 10

Testing instructions

  1. boot env ENABLE_FEATURES=jetpack/server-credentials-advanced-flow yarn run start-jetpack-cloud
  2. verify the settings page now matches the "after" screenshot above

@cbauerman cbauerman added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Sep 7, 2020
@cbauerman cbauerman self-assigned this Sep 7, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Sep 7, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~306 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
jetpack-cloud-settings      +1228 B  (+0.8%)     +306 B  (+0.7%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cbauerman cbauerman changed the base branch from master to add/jetpack-cloud-host-detection September 7, 2020 16:18
@cbauerman cbauerman marked this pull request as ready for review September 7, 2020 16:47
@cbauerman cbauerman requested a review from a team September 7, 2020 16:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 7, 2020
Base automatically changed from add/jetpack-cloud-host-detection to master September 7, 2020 21:01
@cbauerman cbauerman force-pushed the add/jetpack-cloud-host-credentials branch from 2bed747 to 6a92ce6 Compare September 7, 2020 21:30
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I noticed two small issues.

  1. On a small viewport, the Providers container is wider than the rest of the pieces of the UI. Is that expected?

  1. The content inside the <ConnectionStatus /> component is almost overlapping.

@cbauerman
Copy link
Contributor Author

LGTM!

On a small viewport, the Providers container is wider than the rest of the pieces of the UI. Is that expected?

There are a couple outstanding issues w/ styling, especially at the narrower screen sizes. The strategy is too get the functionality done first then circle back to pick up those sort of issues

@cbauerman cbauerman merged commit 890d081 into master Sep 7, 2020
@cbauerman cbauerman deleted the add/jetpack-cloud-host-credentials branch September 7, 2020 22:07
@rcanepa
Copy link
Contributor

rcanepa commented Sep 7, 2020

LGTM!
On a small viewport, the Providers container is wider than the rest of the pieces of the UI. Is that expected?

There are a couple outstanding issues w/ styling, especially at the narrower screen sizes. The strategy is too get the functionality done first then circle back to pick up those sort of issues

Agree! I would do the same. Just pointing them out in case you didn't see them 🙂

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 7, 2020
@a8ci18n
Copy link

a8ci18n commented Sep 7, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4348350

Thank you @cbauerman for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 17, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants