New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jetpack Cloud Settings Host Credentials Status #45434
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~306 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
2bed747
to
6a92ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple outstanding issues w/ styling, especially at the narrower screen sizes. The strategy is too get the functionality done first then circle back to pick up those sort of issues |
Agree! I would do the same. Just pointing them out in case you didn't see them 🙂 |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4348350 Thank you @cbauerman for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Motivation: Add component for top status durning new host-specific credential flow
<ConnectionStatus />
component to new credentials settings pageTesting instructions
env ENABLE_FEATURES=jetpack/server-credentials-advanced-flow yarn run start-jetpack-cloud
settings
page now matches the "after" screenshot above