Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/etk coming soon v2 #45581

Closed
wants to merge 24 commits into from
Closed

Add/etk coming soon v2 #45581

wants to merge 24 commits into from

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Sep 11, 2020 •
edited
Loading

Changes proposed in this Pull Request

Testing instructions

  • D45700-code

Fixes #

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/etk-coming-soon-v2

@lsl lsl mentioned this pull request Sep 11, 2020
Closed
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D49422-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

matticbot commented Sep 11, 2020 •
edited
Loading

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ramonjd
Copy link
Member

ramonjd commented Sep 14, 2020

Could we close #45167 and use this PR as the base show pony (since it's further along)?

Commits match.

@lsl lsl mentioned this pull request Sep 14, 2020
Closed
@ramonjd ramonjd requested a review from a team September 14, 2020 04:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 14, 2020
ramonjd
ramonjd approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well when I set the relevant options

@ramonjd
Copy link
Member

ramonjd commented Sep 14, 2020

Rechecked. Nice changes 👍 No regressions in functionality.

🚢

simison
simison reviewed Sep 14, 2020
View reviewed changes
apps/editing-toolkit/editing-toolkit-plugin/coming-soon/styles.scss
@import '~@automattic/typography/styles/fonts';

html {
/* No admin bar nor marketing bar on this page */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no admin bar tho? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it was done in v1 => D44342-code

In v1 a logged-in user doesn't see the coming soon page.

Makes sense to show the admin bar for logged in users in v2 since they'll be able to view the selected page I guess.

ramonjd and others added 12 commits September 15, 2020 14:49
@ramonjd @roo2
This is a base commit to start off coming soon
b9aaf3d 
Taking great inspiration from #43831
@ramonjd @roo2
Added coming soon on the site setting page - just tooling
31513e6
@ramonjd @roo2
Added selector for coming soon mode status
07e6570 
Renamed wpcom_coming_soon_mode to wpcom_coming_soon
@ramonjd @roo2
rebase cleaning up
793964e
@ramonjd @roo2
Adding some functions (that don't do anything) and some notes for pla…
05dd78b 
…nning
@ramonjd @roo2
Trying to show/hide coming soon page
5cf8f42
@andrewserong @roo2
Update wpcom-coming-soon directory, add fallback-coming-soon-page.php
958ca76
@andrewserong @roo2
Add Recoleta font, unload some things
26b4a6c
@ramonjd @roo2
Filter coming soon pages from public queries
d0a0d7b
@roo2
fix setting the coming soon page on the pages list
0d7a302
@roo2
fix name of coming soon page import
60d42c6
@lsl @roo2
Use wpcom_public_coming_soon option name
de78d92 
- private the singleton constructor
- and a bunch of phpcs workarounds
@lsl lsl mentioned this pull request Sep 17, 2020
Closed
@lsl lsl closed this Oct 2, 2020
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison left review comments

@p-jackson p-jackson p-jackson left review comments

@ramonjd ramonjd ramonjd approved these changes

Assignees

@lsl lsl

Labels
Coming Soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lsl @matticbot @ramonjd @simison @p-jackson @andrewserong @roo2