Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding site setup: use selected features to recommend plan #45718

Merged

Conversation

razvanpapadopol
Copy link

@razvanpapadopol razvanpapadopol commented Sep 17, 2020

Changes proposed in this Pull Request

Testing instructions

  • Go to /new.
  • Select some features on /new/features step and create the site.
  • Apply the diff and sandbox the site.
  • Start Site setup flow in editor and on Select a plan step, Recommended plan should be displayed.

Screenshot

Screenshot 2020-09-17 at 11 30 14

Fixes #45148

@razvanpapadopol razvanpapadopol added the [Goal] New Onboarding previously called Gutenboarding label Sep 17, 2020
@razvanpapadopol razvanpapadopol requested a review from a team September 17, 2020 08:37
@razvanpapadopol razvanpapadopol self-assigned this Sep 17, 2020
@matticbot
Copy link
Contributor

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 17, 2020
@matticbot
Copy link
Contributor

matticbot commented Sep 17, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~12 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding        +87 B  (+0.0%)      -12 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D49718-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @razvanpapadopol for helping us test these changes. Code changes LGTM

@razvanpapadopol razvanpapadopol force-pushed the add/gutenboarding-site-setup-selected-features branch from 9dcd309 to 8b28968 Compare September 17, 2020 12:07
@razvanpapadopol razvanpapadopol merged commit 79aa118 into master Sep 17, 2020
@razvanpapadopol razvanpapadopol deleted the add/gutenboarding-site-setup-selected-features branch September 17, 2020 12:31
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenboarding: save selected features to site options
3 participants