-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevDocs: Use URL interface instead of url package #45898
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~15 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~4657 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4426 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pretty simple usage here, since window.location
will always be an absolute URL.
@@ -137,7 +135,7 @@ const devdocs = { | |||
}, | |||
|
|||
pleaseLogIn: function ( context, next ) { | |||
const currentUrl = url.parse( window.location.href ); | |||
const currentUrl = new URL( window.location.href ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to turn this into a new URL object if you don't want to. window.location
already has all the fields that are accessed below, e.g. window.location.protocol
. This is fine too, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't sure why it's being done so I decided to keep the same logic and just replace the means to get there 😉
Changes proposed in this Pull Request
url
packageTesting instructions
/devdocs/start
as a logged-in user./devdocs/welcome
.Context
Discovered while working on #45523.