Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevDocs: Use URL interface instead of url package #45898

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Sep 24, 2020

Changes proposed in this Pull Request

  • DevDocs: Use URL interface instead of url package

Testing instructions

  • Checkout this branch.
  • Go to /devdocs/start as a logged-in user.
  • Verify you're still correctly redirected to /devdocs/welcome.

Context

Discovered while working on #45523.

@tyxla tyxla added [Type] Enhancement [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. DevDocs labels Sep 24, 2020
@tyxla tyxla requested review from sgomes and a team September 24, 2020 09:01
@tyxla tyxla self-assigned this Sep 24, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~15 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main       -117 B  (-0.0%)      -15 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~4657 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
devdocs     -12195 B  (-5.6%)    -4657 B  (-7.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~4426 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks     +12088 B  (+0.4%)    +4426 B  (+0.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sgomes sgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pretty simple usage here, since window.location will always be an absolute URL.

@@ -137,7 +135,7 @@ const devdocs = {
},

pleaseLogIn: function ( context, next ) {
const currentUrl = url.parse( window.location.href );
const currentUrl = new URL( window.location.href );
Copy link
Contributor

@sgomes sgomes Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to turn this into a new URL object if you don't want to. window.location already has all the fields that are accessed below, e.g. window.location.protocol. This is fine too, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wasn't sure why it's being done so I decided to keep the same logic and just replace the means to get there 😉

@tyxla tyxla merged commit 47d123d into master Sep 24, 2020
@tyxla tyxla deleted the fix/devdocs-url-usage branch September 24, 2020 09:42
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants