Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/remove coming soon option #46034

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Conversation

lsl
Copy link
Contributor

@lsl lsl commented Sep 30, 2020

Changes proposed in this Pull Request

  • Disables the Coming Soon option in under the site settings privacy section if the config flag coming-soon-v2 is enabled.

Testing instructions

yarn run test-client:watch client/my-sites/site-settings/test/form-general.jsx

I've added some basic test coverage but this one probably needs some manual testing to double check the transition works properly.

The below should behave the same regardless of v2 being enabled (e.g. define( 'WPCOM_PUBLIC_COMING_SOON', true ); )

Should show existing coming soon settings, switching to public/private and saving settings should remove the option:

http://calypso.localhost:3000/settings/general/<yourtestsite>.wo\rdpress.com?flags=coming-soon-v2

Should behave like production:

http://calypso.localhost:3000/settings/general/<yourtestsite>.wo\rdpress.com?flags=coming-soon-v2=false

e.g.

http://wordpress.com/settings/general/<yourtestsite>.wo\rdpress.com

props: @roo2 / @ramonjd (alot of code got squashed/rebased out of #45606 / #45896

@matticbot
Copy link
Contributor

@lsl lsl requested review from ramonjd and roo2 September 30, 2020 08:38
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 30, 2020
@lsl lsl self-assigned this Sep 30, 2020
@matticbot
Copy link
Contributor

matticbot commented Sep 30, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~28 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
settings       +121 B  (+0.0%)      +28 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@roo2 roo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the feature flag on and off, it LGTM

@lsl lsl force-pushed the update/remove-coming-soon-option branch from d20585a to 8ff99cd Compare October 1, 2020 06:10
@lsl
Copy link
Contributor Author

lsl commented Oct 1, 2020

Just a rebase, circle ci rerun seems unresponsive.

@lsl lsl merged commit ac74454 into master Oct 1, 2020
@lsl lsl deleted the update/remove-coming-soon-option branch October 1, 2020 07:04
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants