-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/remove coming soon option #46034
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~28 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with the feature flag on and off, it LGTM
d20585a
to
8ff99cd
Compare
Just a rebase, circle ci rerun seems unresponsive. |
Changes proposed in this Pull Request
coming-soon-v2
is enabled.Testing instructions
I've added some basic test coverage but this one probably needs some manual testing to double check the transition works properly.
The below should behave the same regardless of v2 being enabled (e.g.
define( 'WPCOM_PUBLIC_COMING_SOON', true );
)Should show existing coming soon settings, switching to public/private and saving settings should remove the option:
Should behave like production:
e.g.
props: @roo2 / @ramonjd (alot of code got squashed/rebased out of #45606 / #45896