Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premium Content: Fix logged-out view button alignment #46125

Merged
merged 1 commit into from Oct 2, 2020

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Oct 2, 2020

Changes proposed in this Pull Request

  • Set inline block styles on the jetpack Recurring Payments block from within Premium Content styles.
  • Add a right margin to the button on both front end and back end.
  • I went back and forth on where this change should live, but ended up in Premium Content because it appears to be specific to this block, I can't test the Premium Content block on a Jetpack site, and I don't want to conflict with existing uses of Recurring Payments. 😥
  • I tested the styles in a bunch of different themes and did not notice any issues, but it's probably worth taking the block for a spin.

Before

Screen Shot 2020-10-02 at 12 49 21 PM

After

Screen Shot 2020-10-02 at 12 17 33 PM

Screen Shot 2020-10-02 at 12 19 25 PM

Screen Shot 2020-10-02 at 12 26 21 PM

Testing instructions

  • For local development, you'll need to follow the instructions for Editing Toolkit Development in the FG, but it's much easier if you can test the block with calypso.live
  • Add a Premium Content block to your site
  • Check out the button styles on the front end and in the editor; they should be side by side rather than one on top of the other

Fixes #45477

…g this in Premium Content rather than Recurring Payments itself to avoid conflicts since this only appears to be an issue in this block.
@sixhours sixhours requested a review from a team October 2, 2020 17:13
@sixhours sixhours self-assigned this Oct 2, 2020
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 2, 2020
@sixhours sixhours added Premium Content Controlling specific content for paying site visitors. and removed [Status] In Progress labels Oct 2, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D50575-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@blackjackkent
Copy link
Contributor

Looks good to me! Tested and verified in both editor and frontend:
image

@kwight kwight merged commit 0033a5a into master Oct 2, 2020
@kwight kwight deleted the fix/premium-content-button-alignment branch October 2, 2020 21:43
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Premium Content Controlling specific content for paying site visitors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Premium Content: Buttons are not displayed inline.
4 participants