Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Backup pending screen design and copy #46162

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Update Backup pending screen design and copy #46162

merged 3 commits into from
Oct 6, 2020

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Oct 5, 2020 •
edited

Changes proposed in this Pull Request

This PR updates the Backup pending screen to prevent users from contacting support while the site first backup is being made.

Fixes 1197351014149633-as-1197360555544595

Testing instructions

  • Download the PR
  • Run Calypso with yarn start
  • Run Jetpack cloud concurrently with yarn start-jetpack-cloud-p
  • Create a new self-hosted Jetpack site, and purchase Backup or a plan that includes Backup
  • Visit /backup/:site
  • Check that you see the new screen in both environments
  • Check that the copy matches the captures below (watch out the difference between cloud and Calypso), and that the links redirect to the proper places

Screenshots

Jetpack cloud

Desktop
Screen Shot 2020-10-06 at 1 14 41 PM
Mobile
Screen Shot 2020-10-06 at 1 15 00 PM

Calypso

Desktop
Screen Shot 2020-10-06 at 1 14 05 PM

Mobile
Screen Shot 2020-10-06 at 1 14 15 PM

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=improve/backup-pending-screen

a8ci18n
a8ci18n reviewed Oct 5, 2020
View reviewed changes
client/components/jetpack/daily-backup-status/status-card/no-backups-yet.jsx
</div>
<ul className="status-card__link-list">
<li>
<ExternalLink href={ siteUrl }>{ translate( 'Visit your website' ) }</ExternalLink>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 22 times:
translate( 'Visit Your Website' ) ES Score: 8

@matticbot
Copy link
Contributor

matticbot commented Oct 5, 2020 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~309 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
backup      +1511 B  (+0.4%)     +309 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z mentioned this pull request Oct 5, 2020
Merged
@monsieur-z monsieur-z force-pushed the improve/backup-pending-screen branch from 6b5265c to 04e8988 Compare October 6, 2020 16:54
@monsieur-z monsieur-z added [Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Oct 6, 2020
monsieur-z
monsieur-z commented Oct 6, 2020
View reviewed changes
client/components/jetpack/daily-backup-status/status-card/style.scss
.card
.activity-log-item__actor
svg {
.status-card__realtime-details-card .activity-card .card .activity-log-item__actor .gravatar,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some automatic formatting.

@monsieur-z monsieur-z marked this pull request as ready for review October 6, 2020 17:22
@monsieur-z monsieur-z requested a review from a team October 6, 2020 17:22
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 6, 2020
@monsieur-z monsieur-z mentioned this pull request Oct 6, 2020
Merged
elliottprogrammer
elliottprogrammer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great.
LGTM! 👍

@monsieur-z monsieur-z merged commit ba3352d into master Oct 6, 2020
@monsieur-z monsieur-z deleted the improve/backup-pending-screen branch October 6, 2020 18:39
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 6, 2020
@a8ci18n
Copy link

a8ci18n commented Oct 6, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4839133

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 16, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8ci18n a8ci18n a8ci18n left review comments

@elliottprogrammer elliottprogrammer elliottprogrammer approved these changes

Assignees
No one assigned
Labels
[Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@monsieur-z @matticbot @a8ci18n @elliottprogrammer