Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Backup successful state design #46165

Closed
wants to merge 3 commits into from

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Oct 5, 2020

Changes proposed in this Pull Request

This PR updates the Backup successful screen to minimize the number of call-to-actions.

Fixes 1197351014149633-as-1197360555544603

Implementation notes

  • I left post links in their original colour instead of black, for accessibility concerns

Testing instructions

  • Download the PR
  • Run Calypso with yarn start
  • Run Jetpack cloud concurrently with yarn start-jetpack-cloud-p
  • Pick a self-hosted Jetpack site that already has a backup
  • Visit /backup/:site
  • Check that you see the updates in both environments (see captures below)

Screenshots

Jetpack cloud

Before
Screen Shot 2020-10-06 at 1 53 17 PM
Screen Shot 2020-10-06 at 2 16 49 PM

After
screenshot (1)
screenshot

Calypso

Before
Screen Shot 2020-10-06 at 1 53 26 PM
Screen Shot 2020-10-06 at 2 16 19 PM

After
screenshot
screenshot (1)

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Oct 5, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~109 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
backup         +301 B  (+0.1%)      +71 B  (+0.1%)
activity       +127 B  (+0.0%)      +38 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z force-pushed the improve/backup-success-screen branch from 0b3c011 to ea8ee0b Compare October 6, 2020 17:47
@monsieur-z monsieur-z added [Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Oct 6, 2020
.card
.activity-log-item__actor
svg {
.status-card__realtime-details-card .activity-card .card .activity-log-item__actor .gravatar,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic reformatting.

@monsieur-z monsieur-z marked this pull request as ready for review October 6, 2020 18:32
@monsieur-z monsieur-z requested review from elliottprogrammer and a team October 6, 2020 18:32
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 6, 2020
Copy link
Contributor

@elliottprogrammer elliottprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!
LGTM! 👍

@monsieur-z monsieur-z force-pushed the improve/backup-success-screen branch from 3af1fd4 to 553a1c3 Compare October 7, 2020 13:06
@monsieur-z
Copy link
Contributor Author

I'm not sure if the failing check wait-calypso-live will break deployment. I'll deploy #46245 instead, which has the exact same diff and that passes all checks.

@monsieur-z monsieur-z closed this Oct 7, 2020
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants