-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Backup successful state design #46165
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~109 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
0b3c011
to
ea8ee0b
Compare
.card | ||
.activity-log-item__actor | ||
svg { | ||
.status-card__realtime-details-card .activity-card .card .activity-log-item__actor .gravatar, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic reformatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great!
LGTM! 👍
3af1fd4
to
553a1c3
Compare
I'm not sure if the failing check |
Changes proposed in this Pull Request
This PR updates the Backup successful screen to minimize the number of call-to-actions.
Fixes 1197351014149633-as-1197360555544603
Implementation notes
Testing instructions
yarn start
yarn start-jetpack-cloud-p
/backup/:site
Screenshots
Jetpack cloud
Before
After
Calypso
Before
After