Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans: new name and tagline for Jetpack Security and Jetpack Backup #46401

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Plans: new name and tagline for Jetpack Security and Jetpack Backup #46401

merged 4 commits into from
Oct 13, 2020

Conversation

rcanepa
Copy link
Contributor

@rcanepa rcanepa commented Oct 13, 2020 •
edited

Changes proposed in this Pull Request

  • Update Security and Backup product cards with a better name and tagline. Now Jetpack Security is featured as Jetpack Security instead of Security Daily, and Jetpack Backup is featured as Jetpack Backup instead of Backup Daily.

Testing instructions

  • Run this PR.
  • Visit the Plans page (any environment will work).
  • Verify that the name in Jetpack Security and Jetpack Backup cards looks like the capture below.
  • Verify that the tagline in Jetpack Security and Jetpack Backup cards looks like the capture below.

Fixes 1196341175636977-as-1198202253926309

Demo

image
image
image

@rcanepa rcanepa added Jetpack [Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Oct 13, 2020
@rcanepa rcanepa requested review from a team October 13, 2020 13:28
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=improve/3-col-pricing-security-backup-content

@rcanepa rcanepa changed the title Plans: better names and taglines for Jetpack Security and Jetpack Backup Plans: new name and tagline for Jetpack Security and Jetpack Backup Oct 13, 2020
eeeeevon13
eeeeevon13 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@eeeeevon13 eeeeevon13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rcanepa
rcanepa commented Oct 13, 2020
View reviewed changes
client/components/jetpack/card/jetpack-product-card-alt/index.tsx
@@ -41,7 +41,7 @@ type OwnProps = {
billingTimeFrame: TranslateResult;
buttonLabel: TranslateResult;
buttonPrimary: boolean;
badgeLabel: TranslateResult;
badgeLabel?: TranslateResult;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all cards display a badge so it shouldn't be mandatory.

@matticbot
Copy link
Contributor

matticbot commented Oct 13, 2020 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~49 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +98 B  (+0.0%)      +49 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~529 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
plans                       +243 B  (+0.0%)      +52 B  (+0.0%)
jetpack-connect             +243 B  (+0.0%)      +56 B  (+0.0%)
jetpack-cloud-pricing       +243 B  (+0.1%)      +61 B  (+0.1%)
woocommerce                  +97 B  (+0.0%)      +15 B  (+0.0%)
themes                       +97 B  (+0.0%)      +15 B  (+0.0%)
theme                        +97 B  (+0.0%)      +15 B  (+0.0%)
site-purchases               +97 B  (+0.0%)      +15 B  (+0.0%)
signup                       +97 B  (+0.0%)      +15 B  (+0.0%)
settings-writing             +97 B  (+0.0%)      +15 B  (+0.0%)
settings-security            +97 B  (+0.0%)      +15 B  (+0.0%)
settings-performance         +97 B  (+0.0%)      +15 B  (+0.0%)
settings-jetpack             +97 B  (+0.0%)      +15 B  (+0.0%)
settings-discussion          +97 B  (+0.0%)      +15 B  (+0.0%)
settings                     +97 B  (+0.0%)      +15 B  (+0.0%)
purchases                    +97 B  (+0.0%)      +15 B  (+0.0%)
purchase-product             +97 B  (+0.0%)      +15 B  (+0.0%)
marketing                    +97 B  (+0.0%)      +15 B  (+0.0%)
home                         +97 B  (+0.0%)      +15 B  (+0.0%)
help                         +97 B  (+0.0%)      +15 B  (+0.0%)
export                       +97 B  (+0.0%)      +15 B  (+0.0%)
email                        +97 B  (+0.0%)      +15 B  (+0.0%)
domains                      +97 B  (+0.0%)      +15 B  (+0.0%)
customize                    +97 B  (+0.0%)      +15 B  (+0.0%)
checkout                     +97 B  (+0.0%)      +15 B  (+0.0%)
activity                     +97 B  (+0.0%)      +15 B  (+0.0%)
account-close                +97 B  (+0.0%)      +15 B  (+0.0%)
accept-invite                +97 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~148 bytes added 📈 [gzipped])

name                                                      parsed_size           gzip_size
async-load-blocks-inline-help                                   +98 B  (+0.1%)      +41 B  (+0.1%)
async-load-my-sites-sidebar-unified-switcher                    +97 B  (+0.0%)      +15 B  (+0.0%)
async-load-my-sites-sidebar                                     +97 B  (+0.0%)      +15 B  (+0.0%)
async-load-my-sites-current-site-stale-cart-items-notice        +97 B  (+0.1%)      +15 B  (+0.1%)
async-load-design-blocks                                        +97 B  (+0.0%)      +17 B  (+0.0%)
async-load-design                                               +97 B  (+0.0%)      +15 B  (+0.0%)
async-load-blocks-inline-help-popover                           +97 B  (+0.0%)      +15 B  (+0.0%)
async-load-blocks-editor-checkout-modal                         +97 B  (+0.0%)      +15 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n
a8ci18n reviewed Oct 13, 2020
View reviewed changes
client/lib/products-values/translations.js
@@ -130,7 +130,9 @@ export const getJetpackProductsCallToAction = () => {
};

export const getJetpackProductsTaglines = () => {
const backupDailyTagline = translate( 'Best for sites with occasional updates' );
const backupDailyTagline = isEnabled( 'plans/alternate-selector' )
? translate( 'Automated backups with one-click restores' )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 3 times:
translate( 'Automated, daily backups with one-click restores' ) ES Score: 11
See 1 additional suggestions in the PR translation status page

@rcanepa rcanepa force-pushed the improve/3-col-pricing-security-backup-content branch from e8813ea to ff69122 Compare October 13, 2020 14:27
@mattgawarecki
Copy link
Contributor

@rcanepa @eeeeevon13 I see "Backup, Scan, and Anti-spam in one package" instead of "one bundle" if that matters.

@mattgawarecki
Copy link
Contributor

mattgawarecki commented Oct 13, 2020 •
edited

Also, "Automated backups with one-click restores" instead of "Automated backups, one-click restores"

@rcanepa
Copy link
Contributor Author

rcanepa commented Oct 13, 2020

Thanks @mattgawarecki . That's ok. I forgot to update the screenshots and they don't represent the final version of the copy.

@rcanepa rcanepa merged commit a63537b into master Oct 13, 2020
@rcanepa rcanepa deleted the improve/3-col-pricing-security-backup-content branch October 13, 2020 14:55
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 13, 2020
@a8ci18n
Copy link

a8ci18n commented Oct 13, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4968763

Thank you @rcanepa for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 22, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8ci18n a8ci18n a8ci18n left review comments

@mattgawarecki mattgawarecki mattgawarecki approved these changes

@eeeeevon13 eeeeevon13 eeeeevon13 approved these changes

Assignees
No one assigned
Labels
[Feature] Plans & Upgrades All of the plans on WordPress.com and flow for upgrading plans. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcanepa @matticbot @mattgawarecki @a8ci18n @eeeeevon13