Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premium Content Block: Remove the intermediate block UI. #46619

Merged
merged 2 commits into from Oct 21, 2020

Conversation

apeatling
Copy link
Member

Changes proposed in this Pull Request

Remove the intermediate UI when trying to select the parent of a child block.

Before After
There is an intermediate container block UI when selecting the parent block. This is confusing. There is no intermediate container block UI, selecting the parent goes straight to the root premium content block.
2020-10-20 14 14 25 2020-10-20 14 13 23

Testing instructions

  • Check out this branch locally
  • Sync this branch to your sandbox using yarn dev --sync
  • Add a premium content block on a sandboxed site
  • Confirm that selecting the parent block of a child block in either of the two different views selects the room premium block.

Fixes https://github.com/Automattic/view-design/issues/93

@apeatling apeatling added Premium Content Controlling specific content for paying site visitors. Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Oct 20, 2020
@apeatling apeatling requested a review from a team October 20, 2020 21:18
@apeatling apeatling self-assigned this Oct 20, 2020
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 20, 2020
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D51532-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me.

  • Initially tested with master just to see the intermediate UI
  • Applied this branch
  • Re-synced the editing toolkit to my sandbox
  • Tested again
  • The intermediate UI was no longer an option.

The only minor suggestions I have are to add dependencies to the new hooks that select skip the intermediate block selection.

@apeatling
Copy link
Member Author

I've added the dependencies to the hook, thanks for the review! Going to merge this one so I can keep moving with the next changes.

@apeatling apeatling dismissed aaronrobertshaw’s stale review October 21, 2020 17:59

Dependencies added. 👍

@apeatling apeatling merged commit 023540b into master Oct 21, 2020
@apeatling apeatling deleted the remove/premium-block-intermediate-ui branch October 21, 2020 18:14
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin Premium Content Controlling specific content for paying site visitors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants