New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premium Content Block: Remove the intermediate block UI. #46619
Conversation
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D51532-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me.
- Initially tested with master just to see the intermediate UI
- Applied this branch
- Re-synced the editing toolkit to my sandbox
- Tested again
- The intermediate UI was no longer an option.
The only minor suggestions I have are to add dependencies to the new hooks that select skip the intermediate block selection.
apps/editing-toolkit/editing-toolkit-plugin/premium-content/blocks/logged-out-view/edit.js
Outdated
Show resolved
Hide resolved
apps/editing-toolkit/editing-toolkit-plugin/premium-content/blocks/subscriber-view/edit.js
Outdated
Show resolved
Hide resolved
I've added the dependencies to the hook, thanks for the review! Going to merge this one so I can keep moving with the next changes. |
Changes proposed in this Pull Request
Remove the intermediate UI when trying to select the parent of a child block.
Testing instructions
yarn dev --sync
Fixes https://github.com/Automattic/view-design/issues/93