Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Checklist: Update copy for Downtime Monitor on Jetpack checklist #47012

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Jetpack Checklist: Update copy for Downtime Monitor on Jetpack checklist #47012

merged 2 commits into from
Nov 2, 2020

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Nov 2, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • Update copy for Downtime Monitor on Jetpack checklist.

Testing instructions

Screenshots

Before

image

After

image

@keoshi keoshi added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Checklist labels Nov 2, 2020
@keoshi keoshi requested a review from a team November 2, 2020 14:31
@keoshi keoshi self-assigned this Nov 2, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/jetpack-checklist-monitor-copy

@jeffgolenski
Copy link
Member

@keoshi could we swap a few words to allow it to flow a little better? I'd suggest: ..."and alert you with instant notifications the moment your site goes down."

@keoshi keoshi changed the title Update copy for Downtime Monitor on Jetpack checklist Jetpack Checklist: Update copy for Downtime Monitor on Jetpack checklist Nov 2, 2020
@keoshi
Copy link
Contributor Author

keoshi commented Nov 2, 2020

@jeffgolenski Good call. I simply copy/pasted the copy that's being used on our documentation, but I'd even suggest simplifying it further:

Jetpack will continuously watch your site, and alert you with instant notifications when any downtime is detected.

What do you think?

a8ci18n
a8ci18n reviewed Nov 2, 2020
View reviewed changes
client/my-sites/plans/current-plan/jetpack-checklist/index.tsx Outdated
@@ -278,7 +278,7 @@ class JetpackChecklist extends PureComponent< Props & LocalizeProps > {
completedButtonText={ translate( 'Change', { context: 'verb' } ) }
completedTitle={ translate( 'You turned on Downtime Monitoring.' ) }
description={ translate(
"Monitor your site's uptime and alert you the moment downtime is detected with instant notifications."
'Jetpack will continuously watch your site, and alert you the moment that downtime is detected with instant notifications.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 27 times:
translate( 'Jetpack will continuously monitor your site, and alert you the moment downtime is detected.' ) ES Score: 6

@matticbot
Copy link
Contributor

matticbot commented Nov 2, 2020 •
edited
Loading

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scottsweb
Copy link
Contributor

How about:

Jetpack will continuously watch your site, and alert you with instant notifications if downtime is detected.

Switching when to if, as downtime is not guaranteed ™️

@keoshi
Copy link
Contributor Author

keoshi commented Nov 2, 2020

I like that @scottsweb !

@jeffgolenski
Copy link
Member

@keoshi ship it.

jeffgolenski
jeffgolenski approved these changes Nov 2, 2020
View reviewed changes
client/my-sites/plans/current-plan/jetpack-checklist/index.tsx
@@ -278,7 +278,7 @@ class JetpackChecklist extends PureComponent< Props & LocalizeProps > {
completedButtonText={ translate( 'Change', { context: 'verb' } ) }
completedTitle={ translate( 'You turned on Downtime Monitoring.' ) }
description={ translate(
"Monitor your site's uptime and alert you the moment downtime is detected with instant notifications."
'Jetpack will continuously watch your site, and alert you with instant notifications if downtime is detected.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW THSI IS AMAZING!!!111

@keoshi keoshi merged commit f0f4696 into master Nov 2, 2020
@keoshi keoshi deleted the update/jetpack-checklist-monitor-copy branch November 2, 2020 16:51
@matticbot matticbot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 2, 2020
@a8ci18n
Copy link

a8ci18n commented Nov 2, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5100424

Thank you @keoshi for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 13, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8ci18n a8ci18n a8ci18n left review comments

@jeffgolenski jeffgolenski jeffgolenski approved these changes

Assignees

@keoshi keoshi

Labels
Checklist Jetpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keoshi @matticbot @jeffgolenski @scottsweb @a8ci18n