New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focused Launch: fix domain picker not showing in summary page in Calypso #47141
Focused Launch: fix domain picker not showing in summary page in Calypso #47141
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~128 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~299 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~19666 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
- Use React context to provide siteId and update hook to get the correct value always from context.
- Remove @wordpress/core-data dependency from editing-toolkit plugin.
c1046f5
to
e159544
Compare
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D52333-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
…rch prop when showSearchField prop is true.
Code LGTM, and the changes test correctly. Thank you We just need to solve conflicts before being able to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested after solving conflicts, everything still works as expected.
Great job on this PR, it solves at once many small-medium issues
Changes proposed in this Pull Request
use-domain-search
hook to get site title fromuseTitle
hook.siteId
and update all hooks to get the correct value always from context.sitePrimaryDomain, siteSubdomain, hasPaidDomain
touseSiteDomains
hook.domainSearch
state usinginitialDomainSearch
prop whenshowSearchField
prop istrue
.Testing instructions
Check the changes for calypso-dev version
/page/[SITE_ID]/home?flags=create/focused-launch-flow-calypso
on this PR'scalypso.live
site.Compare the in-editor versions (local vs production)
No change is expected here
yarn start
cd apps/editing-toolkit && yarn dev --sync
/start
by adding it to your host filewp.data.dispatch('automattic/launch' ).openFocusedLaunch()
Test Gutenboarding Step-by-step launch flow for regressions
/new
and go to the editor.Fixes #47113
Fixes #47139
Fixes #46956
Fixes #47137
Fixes #47093