Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy updates for Jetpack Scan #47274

Closed
wants to merge 4 commits into from
Closed

Conversation

scottsweb
Copy link
Contributor

@scottsweb scottsweb commented Nov 10, 2020

Changes proposed in this Pull Request

Refinements to copy in the Jetpack Scan UI. Remove odd break.

Before

Screenshot 2020-11-10 at 15 28 18

After

Screenshot 2020-11-10 at 16 15 23

Testing instructions

  • npm run start-jetpack-cloud
  • Check for updated copy in the Scan UI

@scottsweb scottsweb added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2020
@scottsweb scottsweb requested review from a team November 10, 2020 14:37
@scottsweb scottsweb self-assigned this Nov 10, 2020
@matticbot
Copy link
Contributor

client/my-sites/scan/main.tsx Outdated Show resolved Hide resolved
{ translate(
'Please review them below and take action. If you have any questions, we are {{a}}here to help{{/a}}.',
'Please review and take action. If you have any questions, we are {{a}}here to help{{/a}}.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhoop has some updates here too, but I think there's no PR yet? Can probably combine them.

Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two small copy suggestions.

client/my-sites/scan/main.tsx Outdated Show resolved Hide resolved
@matticbot
Copy link
Contributor

matticbot commented Nov 10, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5 bytes removed 📉 [gzipped])

name  parsed_size           gzip_size
scan        +43 B  (+0.0%)       -5 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@scottsweb scottsweb requested a review from a team November 13, 2020 08:52
@scottsweb
Copy link
Contributor Author

@singerb should be good for another review

@singerb singerb requested a review from bhoop November 13, 2020 13:50
@singerb
Copy link

singerb commented Nov 13, 2020

Looks good to me, but as mentioned before I'll tag @bhoop in since he was working on some changes to the "we're here to help" wording I thought. Maybe in a different place though?

@scottsweb
Copy link
Contributor Author

Superseded by #47416

@scottsweb scottsweb closed this Nov 19, 2020
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants