New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy updates for Jetpack Scan #47274
Conversation
{ translate( | ||
'Please review them below and take action. If you have any questions, we are {{a}}here to help{{/a}}.', | ||
'Please review and take action. If you have any questions, we are {{a}}here to help{{/a}}.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhoop has some updates here too, but I think there's no PR yet? Can probably combine them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two small copy suggestions.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~5 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@singerb should be good for another review |
Looks good to me, but as mentioned before I'll tag @bhoop in since he was working on some changes to the "we're here to help" wording I thought. Maybe in a different place though? |
Superseded by #47416 |
Changes proposed in this Pull Request
Refinements to copy in the Jetpack Scan UI. Remove odd break.
Before
After
Testing instructions
npm run start-jetpack-cloud