Reader Lists: improve error notices #47444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Status] Needs Review
bluefuton
commented
Nov 16, 2020
bluefuton
commented
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
a8ci18n
reviewed
Nov 16, 2020
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
jsnmoon
approved these changes
Nov 16, 2020
matticbot
removed
the
[Status] Needs Review
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5209367 Hi @bluefuton, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
|
Translation for this Pull Request has now been finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
As @nb notes in #47219, Reader lists often hands the API error straight back to the user when something goes wrong.
This PR adds more human-friendly error messages for scenarios where the API request has failed.
I've also removed error notices for list loading and list item loading - these are situations where the user hasn't taken a CRUD action and we should handle problems more quietly with just loading placeholders I think (like loading Reader feeds).
Testing instructions
On the development environment, create a new list and make sure the management UI works as expected:
http://calypso.localhost:3000/read/list/new
Fixes #47219.