Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coming soon: check for is_front_page as well #47661

Merged
merged 1 commit into from Nov 23, 2020
Merged

Coming soon: check for is_front_page as well #47661

merged 1 commit into from Nov 23, 2020

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 23, 2020 •
edited

Changes proposed in this Pull Request

A follow up on #47563

Added is front page check for Coming Soon

This catches the blog roll as home page scenario

Testing instructions

#47563

@ramonjd ramonjd added Coming Soon Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Nov 23, 2020
@ramonjd ramonjd requested a review from a team November 23, 2020 05:58
@ramonjd ramonjd self-assigned this Nov 23, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/coming-soon-visibility-checks

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 23, 2020
andrewserong
andrewserong approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this in my sandbox, but visually looks good 👍

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D53146-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@ramonjd ramonjd merged commit 68fecb8 into trunk Nov 23, 2020
@ramonjd ramonjd deleted the update/coming-soon-visibility-checks branch November 23, 2020 06:36
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 23, 2020
@p-jackson p-jackson mentioned this pull request Nov 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewserong andrewserong andrewserong approved these changes

Assignees

@ramonjd ramonjd

Labels
Coming Soon Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramonjd @matticbot @andrewserong