New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to node 12.19.1 #47866
Update to node 12.19.1 #47866
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds well and smoke tests well for me. 👍
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D53528-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phpunit failure observed here is a different problem than the one I described (and we are already tracking it elsewhere). It looks like wp-env is able to startup correctly with this new node version, which is all i wanted to verify 👍
Calypso was updated earlier, in Automattic/wp-calypso#47866 Let's follow suit so when you develop in both environments, you don't have to constantly switch.
Calypso was updated earlier, in Automattic/wp-calypso#47866 Let's follow suit so when you develop in both environments, you don't have to constantly switch.
Changes proposed in this Pull Request
Update Node to
12.19.1
Testing instructions