New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New onboarding launch: use site slug instead of siteId when redirecting #48248
New onboarding launch: use site slug instead of siteId when redirecting #48248
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~8 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D54158-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
aceadea
to
d6eeafc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as described and changes LGTM
…r launch (#48248) * Use siteSlug instead of siteId when redirecting to /checkout. * Use siteSlug when redirecting to My Home after launch.
Changes proposed in this Pull Request
siteId
when redirecting to/checkout
.Testing instructions
/new
/checkout/{SITE_SLUG}
with no errors when loading cart (see Launch: errors after redirect to checkout #47150)./home/{SITE_SLUG}
Fixes #48091
Fixes #47150