Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New onboarding launch: use site slug instead of siteId when redirecting #48248

Merged

Conversation

razvanpapadopol
Copy link

@razvanpapadopol razvanpapadopol commented Dec 11, 2020

Changes proposed in this Pull Request

  • Use site slug instead of siteId when redirecting to /checkout.
  • Use site slug when redirecting to home after launching the site.

Testing instructions

  • Create a site starting from /new
  • Sync ET plugin and sandbox the site
  • Start Launch from the editor and complete the flow by choosing paid plan => redirect to /checkout/{SITE_SLUG} with no errors when loading cart (see Launch: errors after redirect to checkout #47150).
  • Repeat previous steps but choose a Free plan instead => redirect to /home/{SITE_SLUG}

Fixes #48091
Fixes #47150

@razvanpapadopol razvanpapadopol added the [Goal] New Onboarding previously called Gutenboarding label Dec 11, 2020
@razvanpapadopol razvanpapadopol requested a review from a team December 11, 2020 07:46
@razvanpapadopol razvanpapadopol self-assigned this Dec 11, 2020
@matticbot
Copy link
Contributor

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 11, 2020
@matticbot
Copy link
Contributor

matticbot commented Dec 11, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~8 bytes added 📈 [gzipped])

name                                           parsed_size           gzip_size
async-load-calypso-blocks-editor-launch-modal        +60 B  (+0.0%)       +8 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D54158-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@razvanpapadopol razvanpapadopol force-pushed the update/new-onboarding-launch-redirect-using-site-slug branch from aceadea to d6eeafc Compare December 21, 2020 14:16
Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as described and changes LGTM

@razvanpapadopol razvanpapadopol merged commit 5366fe0 into trunk Dec 22, 2020
@razvanpapadopol razvanpapadopol deleted the update/new-onboarding-launch-redirect-using-site-slug branch December 22, 2020 12:05
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 22, 2020
sarayourfriend pushed a commit that referenced this pull request Dec 23, 2020
…r launch (#48248)

* Use siteSlug instead of siteId when redirecting to /checkout.
* Use siteSlug when redirecting to My Home after launch.
@ciampo ciampo mentioned this pull request Jan 6, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New onboarding launch: use site slug instead of siteId in URL Launch: errors after redirect to checkout
3 participants