New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy for store deprecation/removal #48688
Conversation
… update/48479-use-translate-for-strings
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~133 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~77 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 🚀 ! Thank you for cleaning up and making the code more succinct 👍
Looks great. One small thing on the Store dashboard notice would be to just reduce the padding between the paragraph of text and the |
Sure, I'll do this in a separate PR |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5398750 Thank you @becdetat for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Fixes #48479
Fixes #48685
Testing instructions
Sidebar menu tooltip
On the site homepage, with
?flags=woocommerce/store-deprecated
in the URL, a tooltip appears next to the "Store" item:Notice on the store dashboard
On the store dashboard, with
?flags=woocommerce/store-deprecated
in the URL, the following notice appears:With
?flags=woocommerce/store-removed
in the URL, the following notice appears instead (note the copy change) and the rest of the dashboard items are removed:Child pages notice
Go to a child page (eg Products) with
?flags=woocommerce/store-deprecated
in the URL. The following notice should appear: