Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for store deprecation/removal #48688

Merged
merged 5 commits into from Jan 8, 2021

Conversation

becdetat
Copy link
Contributor

@becdetat becdetat commented Jan 6, 2021

Fixes #48479
Fixes #48685

Testing instructions

Sidebar menu tooltip

On the site homepage, with ?flags=woocommerce/store-deprecated in the URL, a tooltip appears next to the "Store" item:
image

Notice on the store dashboard

On the store dashboard, with ?flags=woocommerce/store-deprecated in the URL, the following notice appears:
image

With ?flags=woocommerce/store-removed in the URL, the following notice appears instead (note the copy change) and the rest of the dashboard items are removed:
image

Child pages notice

Go to a child page (eg Products) with ?flags=woocommerce/store-deprecated in the URL. The following notice should appear:
image

@becdetat becdetat added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jan 6, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~133 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
woocommerce       +581 B  (+0.0%)     +133 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~77 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
async-load-calypso-my-sites-sidebar       +104 B  (+0.1%)      +77 B  (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 🚀 ! Thank you for cleaning up and making the code more succinct 👍

@elizaan36
Copy link

Looks great. One small thing on the Store dashboard notice would be to just reduce the padding between the paragraph of text and the Go to WooCommerce Home CTA. Looks like it's 2X the other gaps so thought I'd mention, but it's a small thing.

@becdetat becdetat merged commit 7b64871 into trunk Jan 8, 2021
@becdetat becdetat deleted the update/48479-use-translate-for-strings branch January 8, 2021 01:10
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 8, 2021
@becdetat
Copy link
Contributor Author

becdetat commented Jan 8, 2021

@elizaan36

reduce the padding between the paragraph of text and the Go to WooCommerce Home CTA.

Sure, I'll do this in a separate PR

@a8ci18n
Copy link

a8ci18n commented Jan 8, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5398750

Thank you @becdetat for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jan 15, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store|Woo: Update all store sunset copy Store|Woo: Use 'translate' method for strings
6 participants