New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner Portal: Add static license listing UI #48937
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~42 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~83 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2164 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~44 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
c59a0a1
to
94c6857
Compare
9e181ca
to
a65117b
Compare
…icense border styles pushing content
…due to the detached/revoked label
ab7d49d
to
4162436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to see the LicenceListItem
children abstracted down into their own components somehow, but this can be done in a later PR.
Otherwise this looks fine to ship.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5488793 Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Context:
Changes proposed in this Pull Request
Testing instructions
yarn && yarn start-jetpack-cloud
.Note: Mobile styles were done ad-hoc.
Note: The Partner Portal is only enabled in the development environment for now.