Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Add static license listing UI #48937

Merged
merged 10 commits into from Feb 2, 2021

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented Jan 14, 2021

Context:

  • Project thread: pbtFPC-Um-p2
  • i4 designs: pbtFPC-103-p2

Changes proposed in this Pull Request

  • Introduce the license listing UI with hardcoded placeholder data.

Testing instructions

  • If you do not have a partner key, please contact Infinity for one or you will be unable to view the UI.
  • Checkout PR locally, run yarn && yarn start-jetpack-cloud.
  • Visit http://jetpack.cloud.localhost:3000/partner-portal and select your partner key, if prompted.
  • Confirm the license list UI you are presented with matches designs (minus search, sort, filter, and revoke as they will be added in a separate PR).

Note: Mobile styles were done ad-hoc.
Note: The Partner Portal is only enabled in the development environment for now.

license-listing

@atanas-dev atanas-dev added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Jan 14, 2021
@atanas-dev atanas-dev self-assigned this Jan 14, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jan 14, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~42 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
manifest        +95 B  (+0.3%)      +42 B  (+0.3%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~83 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +469 B  (+0.0%)      +83 B  (+0.0%)
entry-login                 +105 B  (+0.0%)      +26 B  (+0.0%)
entry-gutenboarding         +105 B  (+0.0%)      +26 B  (+0.0%)
entry-domains-landing       +105 B  (+0.0%)      +26 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2164 bytes removed 📉 [gzipped])

name                          parsed_size            gzip_size
jetpack-cloud-partner-portal     +17580 B  (+56.6%)    +4994 B  (+55.6%)
jetpack-connect                    +255 B   (+0.0%)     +279 B   (+0.1%)
google-my-business                 +183 B   (+0.1%)    +1027 B   (+1.2%)
marketing                          -126 B   (-0.0%)     +618 B   (+0.4%)
plans                              +103 B   (+0.0%)      +22 B   (+0.0%)
devdocs                             -31 B   (-0.0%)       -3 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~44 bytes removed 📉 [gzipped])

name                                            parsed_size           gzip_size
async-load-design-wordpress-components-gallery        -31 B  (-0.0%)      -44 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@atanas-dev atanas-dev force-pushed the add/partner-portal-license-list-view branch from c59a0a1 to 94c6857 Compare January 18, 2021 14:53
@atanas-dev atanas-dev marked this pull request as ready for review January 18, 2021 15:12
@atanas-dev atanas-dev added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Jan 18, 2021
@atanas-dev atanas-dev requested review from a team and removed request for a team January 18, 2021 15:14
@atanas-dev atanas-dev added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] In Progress labels Jan 18, 2021
@atanas-dev atanas-dev requested a review from a team January 18, 2021 18:18
@atanas-dev atanas-dev force-pushed the add/partner-portal-license-list-view branch 2 times, most recently from 9e181ca to a65117b Compare January 22, 2021 17:41
@atanas-dev atanas-dev force-pushed the add/partner-portal-license-list-view branch from ab7d49d to 4162436 Compare January 27, 2021 15:05
Copy link
Member

@rcoll rcoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see the LicenceListItem children abstracted down into their own components somehow, but this can be done in a later PR.

Otherwise this looks fine to ship.

@atanas-dev atanas-dev merged commit 4e880f1 into trunk Feb 2, 2021
@atanas-dev atanas-dev deleted the add/partner-portal-license-list-view branch February 2, 2021 17:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2021
@a8ci18n
Copy link

a8ci18n commented Feb 2, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5488793

Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 11, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants