Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Premium Content: Remove from the Editing Toolkit plugin #49561

Merged
merged 3 commits into from Feb 1, 2021
Merged

Premium Content: Remove from the Editing Toolkit plugin #49561

merged 3 commits into from Feb 1, 2021

Conversation

apeatling
Copy link
Member

Changes proposed in this Pull Request

  • Remove the Premium Content block from editing toolkit as it is being added to Jetpack.

Testing instructions

  • Load this branch
  • Open the editor and confirm that you cannot see the Premium Content block
  • Load the master branch of Jetpack, and confirm that the Premium Content block continues to work (you will need to load it on a WordPress.com sandboxed site).

@apeatling apeatling added Premium Content Controlling specific content for paying site visitors. Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Feb 1, 2021
@apeatling apeatling requested a review from a team February 1, 2021 19:54
@apeatling apeatling self-assigned this Feb 1, 2021
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/premium-content-block

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 1, 2021
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D56323-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

stacimc
stacimc approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that:

  1. With just this changeset synced to sandbox, the Premium Content is no longer available
  2. With the Jetpack changes also synced, the Premium Content block is available again

LGTM

@apeatling apeatling merged commit 76474d4 into trunk Feb 1, 2021
@apeatling apeatling deleted the remove/premium-content-block branch February 1, 2021 21:19
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 1, 2021
@apeatling apeatling mentioned this pull request Feb 1, 2021
Merged
6 tasks
@noahtallen noahtallen mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacimc stacimc stacimc approved these changes

Assignees

@apeatling apeatling

Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin Premium Content Controlling specific content for paying site visitors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeatling @matticbot @stacimc