Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newspack blocks to v1.20 #49778

Merged
merged 2 commits into from Feb 5, 2021
Merged

Update newspack blocks to v1.20 #49778

merged 2 commits into from Feb 5, 2021

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Feb 5, 2021

  • bump newspack blocks to v1.20
  • includes fix for specific posts selection
  • includes fixes for all phpcs issues

Test plan:

  1. load these changes on a sandbox and verify that newspack blocks works, and that the issues mentioned in this PR (refactor: get specific posts REST endpoint from localized value newspack-blocks#689) are fixed.

@noahtallen noahtallen added dependencies Pull requests that update a dependency file Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin labels Feb 5, 2021
@noahtallen noahtallen self-assigned this Feb 5, 2021
@matticbot
Copy link
Contributor

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. OSS Citizen labels Feb 5, 2021
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D56595-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@dkoo
Copy link
Contributor

dkoo commented Feb 5, 2021

@noahtallen The updated package looks good on my sandbox. I also pushed a fix in 798f7c4 which will close Automattic/newspack-blocks#687 for Atomic sites. To test, run yarn run build first and make sure it pulls down the new amp/homepage-posts/view.js file into the synced-newspack-blocks folder. Then:

  1. On a test or ephemeral Atomic site, rsync or manually zip the contents of /apps/editing-toolkit/editing-toolkit-plugin and install/activate as a plugin.
  2. Activate the AMP plugin (should be installed on Atomic sites by default) and turn on Standard or Transitional mode.
  3. Create a post and add a Blog Posts block in query mode. Turn on the "load more" option and make sure there are enough posts loading to show the load more functionality.
  4. View the post's front-end with AMP on and confirm that the "load more" button works as expected.

@noahtallen
Copy link
Member Author

Cool, I'll also give that a test!

@dkoo
Copy link
Contributor

dkoo commented Feb 5, 2021

Adding to note that this will address #49707 (but will not close it until ETK is fully redeployed).

Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for 84f1d2d—if the Atomic fix looks good to you, feel free to merge, or @jeffersonrabb can also review if we need a third set of eyes.

@noahtallen noahtallen merged commit a24b339 into trunk Feb 5, 2021
@noahtallen noahtallen deleted the update/newspack-blocks branch February 5, 2021 22:42
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 5, 2021
@noahtallen noahtallen mentioned this pull request Feb 6, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants