New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update newspack blocks to v1.20 #49778
Conversation
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D56595-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@noahtallen The updated package looks good on my sandbox. I also pushed a fix in 798f7c4 which will close Automattic/newspack-blocks#687 for Atomic sites. To test, run
|
Cool, I'll also give that a test! |
Adding to note that this will address #49707 (but will not close it until ETK is fully redeployed). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for 84f1d2d—if the Atomic fix looks good to you, feel free to merge, or @jeffersonrabb can also review if we need a third set of eyes.
798f7c4
to
1870b21
Compare
Test plan: