-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quantity summary to billing purchase history when available #50028
Add quantity summary to billing purchase history when available #50028
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~379 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me although I do have a concern about how the "(renewal)" text added by the backend is localized. Discussion on the backend patch.
I agree with the concerns raised by Payton in the server patch.
I really think we should avoid this upgrade term in user-facing content when we want to refer to the process of adding new mailboxes. It's not clear enough, and we use it for other things such as subscriptions (e.g. see the
In order to be consistent, we could have the following for renewals:
Also, let's ping @Wesco for feedback ☺. |
I understand where you are coming from @stephanethomas . I was initially trying to be consistent with some of the billing emails we already send on purchase, but I think your points are valid. Of course, I would not mind to get @wensco opinion into the mix. |
f63c100
to
d00c44a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this and it looks okay. I left a small comment on the copy.
translate | ||
) { | ||
if ( isRenewal ) { | ||
return translate( 'Renewal for %(quantity)s mailbox', 'Renewal for %(quantity)s mailboxes', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use %(quantity)d
instead of %(quantity)s
.
b59c2d6
to
2bacfd9
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5534928 Thank you @olaseni for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
licensed_quantity_summary
andnew_quantity
for purchase history line items and details and uses it to display contextual information for products with upgradeable quantities.This PR depends on changes from code-D56964.
The purchase billing history UI should look similar to this after changes.
Testing instructions