Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy for pending backups #50046

Merged
merged 2 commits into from Feb 12, 2021
Merged

Conversation

monsieur-z
Copy link
Contributor

Changes proposed in this Pull Request

This PR updates the copy mentioning pending backups in the Backup section, so that users have better expectations.

Fixes 1164141197617539-as-1196090710229513

Testing instructions

  • Download the PR and run both Calypso and cloud concurrently
  • Select a site that doesn't have Backup
  • Purchase a product that has Backup and visit /backup/:site in both platforms
  • Check that the copy matches the capture below
  • In Calypso, clicking "Contact support" should redirect you to /help/contact, with the site selected
  • In cloud, it should open the Jetpack Contact Support page in a new tab

Screenshots

Before
Screen Shot 2021-02-12 at 11 05 43 AM

After
Screen Shot 2021-02-12 at 11 51 54 AM

Calypso contact form
Screen Shot 2021-02-12 at 11 51 46 AM

@monsieur-z monsieur-z added the [Feature] Backups The Jetpack Backup product label Feb 12, 2021
@monsieur-z monsieur-z requested a review from a team February 12, 2021 17:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 12, 2021
@matticbot
Copy link
Contributor


/**
* Internal dependencies
*/
import ExternalLink from 'calypso/components/external-link';
import { JETPACK_CONTACT_SUPPORT, CALYPSO_CONTACT } from 'calypso/lib/url/support';
import { selectedSiteId } from 'calypso/state/help/actions';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a build error from yarn on this line -- I think it's supposed to be selectSiteId?

Suggested change
import { selectedSiteId } from 'calypso/state/help/actions';
import { selectSiteId } from 'calypso/state/help/actions';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How weird I didn't see any error... anyway, thanks!

@mattgawarecki
Copy link
Contributor

After making the change I mentioned above, everything tested out perfectly for me. 👍

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~75 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +105 B  (+0.0%)      +33 B  (+0.0%)
entry-login                 +105 B  (+0.0%)      +33 B  (+0.0%)
entry-gutenboarding         +105 B  (+0.0%)      +31 B  (+0.0%)
entry-domains-landing       +105 B  (+0.0%)      +38 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~151 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
backup       +144 B  (+0.0%)     +151 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z merged commit e4bd011 into trunk Feb 12, 2021
@monsieur-z monsieur-z deleted the impropve/pending-backup-copy-update branch February 12, 2021 19:46
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 12, 2021
@a8ci18n
Copy link

a8ci18n commented Feb 12, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5517298

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Feb 19, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants