New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copy for pending backups #50046
Conversation
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import ExternalLink from 'calypso/components/external-link'; | ||
import { JETPACK_CONTACT_SUPPORT, CALYPSO_CONTACT } from 'calypso/lib/url/support'; | ||
import { selectedSiteId } from 'calypso/state/help/actions'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a build error from yarn on this line -- I think it's supposed to be selectSiteId
?
import { selectedSiteId } from 'calypso/state/help/actions'; | |
import { selectSiteId } from 'calypso/state/help/actions'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How weird I didn't see any error... anyway, thanks!
After making the change I mentioned above, everything tested out perfectly for me. 👍 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~75 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~151 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5517298 Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR updates the copy mentioning pending backups in the Backup section, so that users have better expectations.
Fixes 1164141197617539-as-1196090710229513
Testing instructions
/backup/:site
in both platforms/help/contact
, with the site selectedScreenshots
Before
After
Calypso contact form