Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newspack Blocks to v1.21.0 #50154

Merged
merged 1 commit into from Feb 16, 2021
Merged

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 16, 2021

To test:

@matticbot
Copy link
Contributor

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 16, 2021
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D57166-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can verify that this fixes Automattic/newspack-blocks#700 for the Blog Posts block
✅ On Simple Sites by applying D57166-code
✅ On a Jetpack site by running this build of the Editing Toolkit plugin

@dkoo dkoo merged commit 2b44983 into trunk Feb 16, 2021
@dkoo dkoo deleted the update/etk-newspack-blocks-1.21.0 branch February 16, 2021 23:26
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 16, 2021
@noahtallen
Copy link
Member

The PHPlint also works great locally, even after removing the override we had for newspack blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants