-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner Portal: Add a Terms of Service consent gate to access the portal #51289
Conversation
client/jetpack-cloud/sections/partner-portal/primary/terms-of-service-consent/index.tsx
Show resolved
Hide resolved
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~849 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~288 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
The functionality tests well. Besides the blockers, I would only ping @keoshi to check the UI before releasing it. |
This looks good to me so far. Would like to see what the rest of the UI looks like... Are we showing menus when the TOS is display? I don't think we should show anything until the TOS are accepted, right? I can also spin the PR later today and test it for myself, but that would be my only concern for now. Finally, just said this to @atanas-dev but will say it again — apologies for not having replied here sooner. I got the email ping but it's been sitting on my todo list because I'm extra busy lately. |
89ce0ff
to
c7f1130
Compare
a43c908
to
96c32cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
96c32cf
to
2af1de5
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5702430 Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Context: p1616184557016100-slack-CQN0YDYM7
Changes proposed in this Pull Request
Testing instructions
yarn && yarn start-jetpack-cloud
.Case 1: You don't have a partner or at least 1 active partner key.
Case 2: You have an active partner key but you have not accepted the new ToS.
Case 3: You have an active partner key and you have already accepted the new ToS once.