Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Add a Terms of Service consent gate to access the portal #51289

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented Mar 22, 2021

Context: p1616184557016100-slack-CQN0YDYM7

Changes proposed in this Pull Request

  • Add a Terms of Service consent gate to access the Partner Portal.

Testing instructions

  • If you do not have a partner key, please contact Infinity for one or you will be unable to view test this PR.
  • Check out this PR locally, then run yarn && yarn start-jetpack-cloud.

Case 1: You don't have a partner or at least 1 active partner key.

Case 2: You have an active partner key but you have not accepted the new ToS.

  • Visit http://jetpack.cloud.localhost:3000/partner-portal
  • You should be redirected to /partner-portal/terms-of-service:
    Screenshot 2021-04-13 at 15 55 19
  • Accepting the terms should redirect you to key selection if you have multiple keys or to your license listing if you only have a single key.

Case 3: You have an active partner key and you have already accepted the new ToS once.

@atanas-dev atanas-dev added [Status] In Progress Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Mar 22, 2021
@atanas-dev atanas-dev self-assigned this Mar 22, 2021
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Mar 22, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~849 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
jetpack-cloud-partner-portal      +3805 B  (+3.4%)     +849 B  (+2.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~288 bytes added 📈 [gzipped])

name                                              parsed_size           gzip_size
async-load-calypso-components-jetpack-portal-nav       +951 B  (+3.7%)     +288 B  (+3.7%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@atanas-dev atanas-dev requested a review from a team March 23, 2021 18:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 23, 2021
@IanRamosC
Copy link
Contributor

The functionality tests well. Besides the blockers, I would only ping @keoshi to check the UI before releasing it.

@keoshi
Copy link
Contributor

keoshi commented Mar 26, 2021

This looks good to me so far. Would like to see what the rest of the UI looks like... Are we showing menus when the TOS is display? I don't think we should show anything until the TOS are accepted, right?

I can also spin the PR later today and test it for myself, but that would be my only concern for now.

Finally, just said this to @atanas-dev but will say it again — apologies for not having replied here sooner. I got the email ping but it's been sitting on my todo list because I'm extra busy lately.

@atanas-dev atanas-dev marked this pull request as ready for review April 9, 2021 14:45
Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@atanas-dev atanas-dev merged commit 9ece048 into trunk Apr 13, 2021
@atanas-dev atanas-dev deleted the add/partner-portal-tos-gate branch April 13, 2021 12:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 13, 2021
@a8ci18n
Copy link

a8ci18n commented Apr 13, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5702430

Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 22, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants