Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Create a site menu" checklist item #52077

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented Apr 19, 2021

Simple text change so that the onboarding checklist makes more sense as site menus are automatically created

fixes #44240

Testing instructions

https://calypso.live/new?branch=update/update-text-on-checklist
Create a site with the /new flow
the checklist text should now say "Edit the site menu"

@roo2 roo2 requested a review from a team as a code owner April 19, 2021 22:50
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 19, 2021
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@roo2 roo2 requested review from a team and removed request for a team April 19, 2021 22:51
@roo2 roo2 self-assigned this Apr 19, 2021
Copy link
Contributor

@autumnfjeld autumnfjeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
image

@roo2 roo2 merged commit f9e1482 into trunk Apr 22, 2021
@roo2 roo2 deleted the update/update-text-on-checklist branch April 22, 2021 04:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 22, 2021
@a8ci18n
Copy link

a8ci18n commented Apr 22, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5753127

Hi @roo2, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Edit the site menu

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Apr 30, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Screen: Checklist step asks users to add a menu — when one is created by default already
4 participants