Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Portal: Add the full blog url in the license details card #52778

Merged
merged 1 commit into from May 13, 2021

Conversation

atanas-dev
Copy link
Member

@atanas-dev atanas-dev commented May 12, 2021

Context: pbtFPC-103-p2#comment-3459

Changes proposed in this Pull Request

  • Partner Portal: Add the full blog url in the license details card

Testing instructions

  1. If you do not have a partner key, please contact Infinity for one or you will be unable to view test this PR.
  2. Check out this PR locally, then run yarn && yarn start-jetpack-cloud.
  3. Assign 2 licenses to 2 different sites on the same domain but in different subdirectories. A multisite setup on JN works very well for this.
  4. Expand the 2 assigned licenses' details cards to confirm their full URL is visible.

@atanas-dev atanas-dev self-assigned this May 12, 2021
@atanas-dev atanas-dev requested a review from a team May 12, 2021 10:57
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2021
@atanas-dev atanas-dev added the Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) label May 12, 2021
@github-actions
Copy link

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~20 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
jetpack-cloud-partner-portal       +287 B  (+0.2%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@IanRamosC IanRamosC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it looks good!

@atanas-dev atanas-dev merged commit 94cec41 into trunk May 13, 2021
@atanas-dev atanas-dev deleted the add/partner-portal-license-full-url branch May 13, 2021 11:56
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants