New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mobile display of the new email plans page #52912
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~11 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
4b85a16
to
56ba23c
Compare
56ba23c
to
61708af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine except for admin badges which are displayed too far from mailboxes:
This is caused by some right padding we always apply to mailboxes as a way - I suppose - to keep them from overlapping the ellipsis menu on narrow viewports. I think we could address that by relying on flex for positioning that particular menu instead of using absolute coordinates (which frankly we should avoid as much as possible as this is always a source of problems when making a design responsive).
Hum, I see now that this may be blocking some other enhancements so I'm totally fine with merging that pull request as it-is, and eventually addressing the issue I've raised in a future iteration. |
For context, the rest of the card is already using flex, which is part of the problem - the other items need to flow differently from this one. That was actually the source of the problem -- when the other items were using |
Approved 🚢. |
Changes proposed in this Pull Request
This PR includes the following improvements:
Testing instructions
/email/:siteSlug
Screenshots
Before
After
Left spacing for warnings
Ellipsis menu alignment and overflow