New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screen options: Handle switches to WP Admin views #53866
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-8584 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~2612 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few minor comments but overall LGTM and works as expected. Thanks for adding the additional component tests too 🙌🏻
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6065286 Hi @mmtr, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Fixes #53708
Changes proposed in this Pull Request
Handles clicks on the new screen switcher component and redirect users to WP Admin when the Classic view is selected.
Testing instructions
?flags=nav-unification/switcher
to the end of the URL.preferred-view=classic
param (which will be used in a future diff for storing the new preference).