Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Remove unnecessary spacing on auto-loading homepage confirmation modal. #53961

Merged
merged 3 commits into from Jun 23, 2021

Conversation

blackjackkent
Copy link
Contributor

Changes proposed in this Pull Request

  • The auto-loading homepage confirmation modal on the theme showcase has a min-height on its description paragraph in mobile to prevent controls jumping around when changing the selected radio button (which changes the text).
  • This is not necessary on desktop and in fact adds extra spacing that looks weird, so this update removes it from medium-breakpoint screens and above.
  • This PR also fixes an issue which was preventing demo homepage preview images from completely filling their container.

Before:
CleanShot 2021-06-23 at 15 18 12@2x

After:
CleanShot 2021-06-23 at 15 16 42@2x

Testing instructions

  • Navigate to Theme Showcase -> Click on three dots menu of a recommended theme (Ideally TwentyTwentyOne since it has a colored background) -> Click activate
  • Verify that the modal popup does not have unnecessary space between description paragraph and buttons.
  • Verify that right-hand preview image fills whole container.

Related to p1624477808051100-slack-C0202PMUXLJ

@blackjackkent blackjackkent requested a review from a team June 23, 2021 20:20
@blackjackkent blackjackkent self-assigned this Jun 23, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 23, 2021
@sixhours
Copy link
Contributor

The right-hand screenshot does fill the container now, but it's stretched. I'm fiddling with the CSS to see if I can find the happy medium between the iframe and the screenshot.

@matticbot
Copy link
Contributor

matticbot commented Jun 23, 2021

@matticbot
Copy link
Contributor

matticbot commented Jun 23, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~9 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
themes        +73 B  (+0.0%)       +9 B  (+0.0%)
theme         +73 B  (+0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@blackjackkent blackjackkent merged commit cf9d024 into trunk Jun 23, 2021
@blackjackkent blackjackkent deleted the update/auto-loading-homepage-modal-spacing branch June 23, 2021 20:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 23, 2021
@a8ci18n
Copy link

a8ci18n commented Jun 23, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6068542

Thank you @blackjackkent for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 30, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants