-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme Showcase: Magic Search Welcome Bar: Add an advanced toggle (Redux) #54218
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-9350 |
Original PR: #54184 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~131 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this still works as expected and it does not show unless the flag is enabled. 👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6117121 Thank you @mreishus for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
^ BEFORE PR
^ AFTER PR
^ AFTER PR
Testing instructions
Testing both flag states:
yarn && ENABLE_FEATURES=theme/showcase-revamp yarn start
yarn && yarn start
How to test:
#54077