Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Showcase: Magic Search Welcome Bar: Add an advanced toggle (Redux) #54218

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Jul 1, 2021

Changes proposed in this Pull Request

  • In the theme showcase, the "Magic Search Welcome Bar" will only appear after an advanced toggle is clicked

2021-06-30_14-10
^ BEFORE PR

2021-06-30_14-09
^ AFTER PR

2021-06-30_14-09_1
^ AFTER PR

Testing instructions

Testing both flag states:

  • Start with flag enabled
    • yarn && ENABLE_FEATURES=theme/showcase-revamp yarn start
    • Changes should be visible
  • Start with flag disabled
    • yarn && yarn start
    • Changes should not be visible

How to test:

  • Visit Calypso.
  • Choose Appearance -> Themes in sthe sidebar
  • Click "Show All Themes"
  • Use the newly revealed search
  • On local dev, if you are sandboxing public api, you may not be able to load the page directly. Some workarounds are here: paYKcK-144-p2

#54077

@matticbot
Copy link
Contributor

matticbot commented Jul 1, 2021

@mreishus mreishus requested a review from a team July 1, 2021 16:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 1, 2021
@mreishus mreishus self-assigned this Jul 1, 2021
@mreishus mreishus added the [Pod] Design Selection Issues related to the WP.com Design Selection focus pod. label Jul 1, 2021
@mreishus
Copy link
Contributor Author

mreishus commented Jul 1, 2021

Original PR: #54184

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~131 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
themes       +560 B  (+0.1%)     +131 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@sixhours sixhours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this still works as expected and it does not show unless the flag is enabled. 👍

@mreishus mreishus merged commit 932b4ce into trunk Jul 1, 2021
@mreishus mreishus deleted the add/theme-showcase-welcome-bar-toggle-2 branch July 1, 2021 20:49
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 1, 2021
@a8ci18n
Copy link

a8ci18n commented Jul 1, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6117121

Thank you @mreishus for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 9, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pod] Design Selection Issues related to the WP.com Design Selection focus pod.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants