-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts domain names to logmein links #54595
Conversation
|
||
return { | ||
title: translate( 'Success!' ), | ||
message: translate( | ||
'Thank your for verifying your contact information for:{{br /}}{{strong}}%(domain)s{{/strong}}.', | ||
'Thank your for verifying your contact information for:{{br /}}{{strong}}{{domainLinks /}}{{/strong}}.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~64 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6245766 Thank you @aneeshd16 for including a screenshot in the description! This is really helpful for our translators. |
@aneeshd16 A note that we needn't wait for translations because the string modifications here only change the arguments in the string, and there are no copy changes. So, the same translations can be used. You can see in the following link that the "new" strings are marked fuzzy and show the previous translations. If you can verify that the same translations will hold good here, you could "Approve" the strings in the Details section. https://translate.wordpress.com/projects/wpcom/-all-translated/686035/ |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This change converts domains to logmein links on domain contact verification page
Testing instructions
?logmein=1
appended)Fixes #54548