Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts domain names to logmein links #54595

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

aneeshd16
Copy link
Contributor

Changes proposed in this Pull Request

This change converts domains to logmein links on domain contact verification page

Testing instructions

  • Update the WHOIS details on an ICANN-regulated TLD (gTLDs like com, blog, etc.) and set new first, last or email fields. This should trigger the verification email.
  • The link in the email goes through public-api first so you might need to edit it to get to the real link, you can also use this JS snippet:
(new URL(<URL in email>)).searchParams.get('redirect_to').replace('https://wordpress.com','http://calypso.localhost:3000')
  • You should see that the domains have been converted to logmein links (with ?logmein=1 appended)
    image
  • Reload the page, this will show the "already verified" screen which also contains the logmein link for the domain.

image

Fixes #54548

@aneeshd16 aneeshd16 added this to In Progress in 3rd party cookies pod via automation Jul 15, 2021
@aneeshd16 aneeshd16 self-assigned this Jul 15, 2021
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 15, 2021
@delputnam delputnam requested a review from a team July 15, 2021 11:32
@delputnam delputnam added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Jul 15, 2021

return {
title: translate( 'Success!' ),
message: translate(
'Thank your for verifying your contact information for:{{br /}}{{strong}}%(domain)s{{/strong}}.',
'Thank your for verifying your contact information for:{{br /}}{{strong}}{{domainLinks /}}{{/strong}}.',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~64 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-domains-landing       +147 B  (+0.0%)      +64 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@lsl lsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3rd party cookies pod automation moved this from In Progress to Reviewer Approved Jul 19, 2021
@aneeshd16 aneeshd16 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jul 19, 2021
@a8ci18n
Copy link

a8ci18n commented Jul 19, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6245766

Thank you @aneeshd16 for including a screenshot in the description! This is really helpful for our translators.

@niranjan-uma-shankar
Copy link
Contributor

@aneeshd16 A note that we needn't wait for translations because the string modifications here only change the arguments in the string, and there are no copy changes. So, the same translations can be used. You can see in the following link that the "new" strings are marked fuzzy and show the previous translations. If you can verify that the same translations will hold good here, you could "Approve" the strings in the Details section.

https://translate.wordpress.com/projects/wpcom/-all-translated/686035/

@a8ci18n
Copy link

a8ci18n commented Jul 26, 2021

Translation for this Pull Request has now been finished.

@aneeshd16 aneeshd16 merged commit e0c12ae into trunk Jul 26, 2021
3rd party cookies pod automation moved this from Reviewer Approved to Done Jul 26, 2021
@aneeshd16 aneeshd16 deleted the add/contact-verification-domain-links branch July 26, 2021 10:51
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Development

Successfully merging this pull request may close these issues.

Convert domains to logmein links on domain contact verification page
6 participants