Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use A Domain I Own: Adding in transfer and connect actions #55644

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

delputnam
Copy link
Contributor

@delputnam delputnam commented Aug 20, 2021

Changes proposed in this Pull Request

This is the next step in the new "Use a domain I own" flow.

Once the "Transfer or Connect" pages are complete, we will need to allow the user to purchase the transfer or mapping or to add the mapping without a purchase in cases where the site is already on a paid plan.

Testing instructions

Load the page at /domains/add/use-my-domain/[blog slug] with an optional query string to specify the domain that will be mapped or transferred: ?initialQuery=[domain name]

When you get to the page that shows the options to transfer or connect, try both options on sites both with and without a paid plan.

When connecting a site with a paid plan, make sure that the domain is connected without going through the purchase step.
When connecting a site without a paid plan, make sure that the mapping is added to the cart and you are redirected to the purchase page.
When selecting transfers, you should be redirected to the transfer pre check page. Make sure you can properly start a transfer.

Screen capture of connecting a domain without going through the purchase flow:

Screen.Recording.2021-08-23.at.12.07.27.PM.mov

Screen capture of connecting a domain by purchasing a mapping:

Screen.Recording.2021-08-23.at.12.05.28.PM.mov

Screen capture of transferring a domain (Yes, domain has been locked and auth code has been changed after recording):

Screen.Recording.2021-08-23.at.2.10.06.PM.mov

For translators.
This is a screenshot including the notice in the top right of the screen with the new translation that is shown once the domain is successfully mapped:

Screen Shot 2021-08-25 at 3 15 05 PM

@github-actions
Copy link

github-actions bot commented Aug 20, 2021

@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications update/handle-transfer-and-connect-purchases on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update/handle-transfer-and-connect-purchases on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

.then( () => {
dispatch(
successNotice(
__( 'Domain connected! Please make sure to follow the next steps below.' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Domain mapping added! Please make sure to follow the next steps below.' ) ES Score: 7

@matticbot
Copy link
Contributor

matticbot commented Aug 20, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~31 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +205 B  (+0.0%)      +31 B  (+0.0%)
entry-login                 +205 B  (+0.0%)      +31 B  (+0.0%)
entry-gutenboarding         +205 B  (+0.0%)      +31 B  (+0.0%)
entry-domains-landing       +205 B  (+0.0%)      +31 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~301 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +1069 B  (+0.1%)     +301 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@delputnam delputnam force-pushed the update/handle-transfer-and-connect-purchases branch from 4b012bc to b258eb6 Compare August 23, 2021 13:19
@delputnam delputnam added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. and removed [Status] In Progress labels Aug 23, 2021
@delputnam delputnam requested a review from a team August 23, 2021 19:08
@delputnam delputnam marked this pull request as ready for review August 23, 2021 19:45
@delputnam delputnam requested a review from a team as a code owner August 23, 2021 19:45
}
);
} )
.catch( ( error ) => setDomainNameValidationError( error ) )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nitpicky, but if only error is being used, you can simplify it:

Suggested change
.catch( ( error ) => setDomainNameValidationError( error ) )
.catch( setDomainNameValidationError )

Copy link
Contributor

@rafaelgallani rafaelgallani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that videos 1 and 2 have their labels inverted... 😅

Checked that both "Connect" options and the "Transfer" one are working as intended.

Transfer

image

Connect

Without a plan (checkout page, clicking on the button redirects you to the domain connect setup):

image

With a plan (Connect setup):

image

I left a single nitpicky comment, but LGTM!

@delputnam delputnam merged commit ceeceb1 into trunk Aug 25, 2021
@delputnam delputnam deleted the update/handle-transfer-and-connect-purchases branch August 25, 2021 12:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 25, 2021
@a8ci18n
Copy link

a8ci18n commented Aug 25, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6475414

Thank you @delputnam for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 5, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants