Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Add atomic site verification for "change site address" #55773

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

rafaelgallani
Copy link
Contributor

@rafaelgallani rafaelgallani commented Aug 26, 2021

Changes proposed in this Pull Request

If the site is not Atomic, then the option for changing the site's free address will be listed/enabled. Otherwise, the option is not listed.
Also, the "manage" button for the free site now is only visible if there's a least one option enabled on it - either changing the free address or setting the free domain as primary. If both conditions are not met, then the button will not be visible.

Preview

Non-atomic site

non-atomic-with-plan

Atomic site (with a custom domain)

atomic-with-custom-domain

Atomic site (without a custom domain)

atomic-without-custom-domain

Manually browsing to the change free site address page on atomic site

image

Testing instructions

  • Go to the domain management page;
  • Check the "manage" button visibility:
    • Check that the button is not visible for atomic sites with no custom domain;
    • Check that the button is visible for atomic sites with a custom domain and without the free domain marked as primary;
    • Check that the button is visible for non-atomic sites;
  • Check that it is not possible to change the free site address when manually browsing to the page on an atomic site (/domains/manage/:site-slug/change-site-address/:primary-domain)
  • Make sure that tests won't break. 😛

Fixes #55764.

@rafaelgallani rafaelgallani added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Aug 26, 2021
@rafaelgallani rafaelgallani requested a review from a team August 26, 2021 20:12
@rafaelgallani rafaelgallani self-assigned this Aug 26, 2021
@github-actions
Copy link

github-actions bot commented Aug 26, 2021

@rafaelgallani
Copy link
Contributor Author

Rebasing on trunk to get the E2E tests updated.

@rafaelgallani rafaelgallani force-pushed the fix/block-change-address-for-atomic-sites branch from 7611c68 to 88aa72a Compare August 26, 2021 20:16
@matticbot
Copy link
Contributor

matticbot commented Aug 26, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~76 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +315 B  (+0.0%)      +76 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@delputnam delputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the quick fix on this issue. 🙇

@rafaelgallani rafaelgallani merged commit 98233a6 into trunk Aug 26, 2021
@rafaelgallani rafaelgallani deleted the fix/block-change-address-for-atomic-sites branch August 26, 2021 22:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 26, 2021
@a8ci18n
Copy link

a8ci18n commented Aug 26, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6487030

Thank you @rafaelgalani for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 27, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Change site address' visible for AT sites
4 participants