Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boilerplate components for transfer flow #56178

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

delputnam
Copy link
Contributor

Changes proposed in this Pull Request

We're getting ready to add a new transfer domain flow. This PR adds the boilerplate components for this flow and a feature flag to gate use of the new flow.

Note: This code is not complete, but only a starting point for additional features that will be added in subsequent PRs.

Testing instructions

Start the "Use a domain I own" flow with the ?flags=domains/new-transfer-flow query string.

Inspect the code.

@delputnam delputnam self-assigned this Sep 11, 2021
@github-actions
Copy link

github-actions bot commented Sep 11, 2021

[ stepSlug.TRANSFER_AUTH_CODE ]: {
mode: modeType.TRANSFER,
step: stepType.ENTER_AUTH_CODE,
name: __( 'Get domain authorization code' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 25 times:
translate( 'Get a domain authorization code.' ) ES Score: 10

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~453 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +1491 B  (+0.1%)     +453 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rafaelgallani rafaelgallani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

next: 'unused transfer domain step',
prev: stepSlug.TRANSFER_UNLOCK,
},
[ 'unused transfer domain step' ]: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked this solution for the breadcrumb 😄

@delputnam delputnam marked this pull request as ready for review September 20, 2021 13:50
@delputnam delputnam requested a review from a team as a code owner September 20, 2021 13:50
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2021
@delputnam delputnam added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Sep 20, 2021
@delputnam delputnam merged commit 118222e into trunk Sep 20, 2021
@delputnam delputnam deleted the add/transfer-domain-flow-boilerplate branch September 20, 2021 14:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 20, 2021
@a8ci18n
Copy link

a8ci18n commented Sep 20, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6637828

Hi @delputnam, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Unlock domain
  • Finalize transfer

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 1, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants