-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boilerplate components for transfer flow #56178
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14629 |
[ stepSlug.TRANSFER_AUTH_CODE ]: { | ||
mode: modeType.TRANSFER, | ||
step: stepType.ENTER_AUTH_CODE, | ||
name: __( 'Get domain authorization code' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 25 times:
translate( 'Get a domain authorization code.' )
ES Score: 10
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~453 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
next: 'unused transfer domain step', | ||
prev: stepSlug.TRANSFER_UNLOCK, | ||
}, | ||
[ 'unused transfer domain step' ]: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this solution for the breadcrumb 😄
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6637828 Hi @delputnam, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
We're getting ready to add a new transfer domain flow. This PR adds the boilerplate components for this flow and a feature flag to gate use of the new flow.
Note: This code is not complete, but only a starting point for additional features that will be added in subsequent PRs.
Testing instructions
Start the "Use a domain I own" flow with the
?flags=domains/new-transfer-flow
query string.Inspect the code.