Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desktop: update docs #56228

Merged
merged 6 commits into from
Sep 15, 2021
Merged

desktop: update docs #56228

merged 6 commits into from
Sep 15, 2021

Conversation

nsakaimbo
Copy link
Contributor

@nsakaimbo nsakaimbo commented Sep 13, 2021 •
edited
Loading

Description

Updates desktop app docs:

  • Remove irrelevant doc on desktop secrets
  • Update release docs
  • Update development docs
  • Update main README

@nsakaimbo
Delete secrets.md
0a711ae 
The desktop app does not authenticate via OAuth, so this information is no longer relevant.
@nsakaimbo
Update release.md
56d01ad
@nsakaimbo
Update development docs
414cb76
@nsakaimbo
Update main README
1b35eb0
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2021
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2021 •
edited
Loading

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14816
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14816&env=jetpack

@github-actions
Copy link

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-1b35eb08b6d8b495ceb10bb08649bee283f1dcfd
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-1b35eb08b6d8b495ceb10bb08649bee283f1dcfd&env=jetpack
(These links may take a few minutes to be available)

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

sandymcfadden
sandymcfadden approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@sandymcfadden sandymcfadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor suggestions as other comments but other then that it looks good!

desktop/README.md Outdated Show resolved Hide resolved
desktop/docs/development.md Outdated Show resolved Hide resolved
@nsakaimbo
Copy link
Contributor Author

Thanks for the review, @sandymcfadden! Addressed your feedback, and made a few more little tweaks.

@nsakaimbo nsakaimbo merged commit 62ca02c into trunk Sep 15, 2021
@nsakaimbo nsakaimbo deleted the desktop-update-docs branch September 15, 2021 16:43
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandymcfadden sandymcfadden sandymcfadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nsakaimbo @matticbot @sandymcfadden