Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to slack connection #56534

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Updates to slack connection #56534

merged 2 commits into from
Oct 4, 2021

Conversation

unDemian
Copy link
Member

@unDemian unDemian commented Sep 24, 2021

Changes proposed in this Pull Request

Fixes 3748-gh-Automattic/p2 by updating the messages and screenshots that can be seen in Calypso.

Testing instructions

See 3748-gh-Automattic/p2

@github-actions
Copy link

github-actions bot commented Sep 24, 2021

@matticbot
Copy link
Contributor

matticbot commented Sep 24, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~58 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing       +357 B  (+0.1%)      +58 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@unDemian unDemian requested a review from a team September 24, 2021 09:09
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2021
@unDemian unDemian removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 24, 2021
@github-actions github-actions bot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2021
Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

…m:Automattic/wp-calypso into trunk

 updates/to-slack-connection
@unDemian unDemian merged commit e4bcf2c into trunk Oct 4, 2021
@unDemian unDemian deleted the updates/to-slack-connection branch October 4, 2021 11:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 4, 2021
@a8ci18n
Copy link

a8ci18n commented Oct 4, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6722047

Hi @unDemian, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Workspace connected to Slack.
  • Connect this workspace to your Slack.
  • Get Slack notifications with every new P2 post.
  • Get {{strong}}Slack notifications{{/strong}} with every new P2 post.
  • Preview posts and pages directly from Slack.
  • {{strong}}Preview posts and pages{{/strong}} directly from Slack.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 14, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants