-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Reduce title length in siteless post-checkout UI #56937
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-16591 |
@keoshi LGTM. If you want to avoid the passive voice, we could also do: "We'll activate your subscription soon." |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~12 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
@rcanepa I believe that change was made already: https://github.com/Automattic/wp-calypso/pull/56937/files#diff-e3c5865394c7fd90760e374a2d5b9ab749bc1534e13b535a5a01304b5af417e6R54 — I cannot find other instances of that string, is there any other place I should be looking at? |
Oh, I can't believe I missed that. You're right. This PR handles both UIs: the one for users who get their subscriptions automatically provisioned and the one for those who don't. 🚢 |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6761529 Thank you @keoshi for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Testing instructions
http://wordpress.com
forhttp://calypso.localhost:3000
in the URL.Screenshots