Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Reduce title length in siteless post-checkout UI #56937

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Oct 11, 2021

Changes proposed in this Pull Request

  • Reduce title length in siteless post-checkout UI.
  • Move product name to the description below.

Testing instructions

  • Fire up this branch.
  • Go to Jetpack.com and select a product.
  • Once in the checkout, replace http://wordpress.com for http://calypso.localhost:3000 in the URL.
  • Complete the purchase.
  • In the post-purchase UI, confirm you see the changes.

Screenshots

Before After
image image

@keoshi keoshi added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Post Checkout labels Oct 11, 2021
@keoshi keoshi requested review from a team October 11, 2021 12:15
@keoshi keoshi self-assigned this Oct 11, 2021
@keoshi keoshi requested a review from a team as a code owner October 11, 2021 12:15
@github-actions
Copy link

github-actions bot commented Oct 11, 2021

@github-actions github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Oct 11, 2021
@madebynoam
Copy link

@keoshi LGTM. If you want to avoid the passive voice, we could also do:

"We'll activate your subscription soon."

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +107 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Looks much better now!

This made me realize we have the same issue on the UI we show after a successful transfer.

Is this something you can handle? If not, I would happily add a ticket to our Maintenance board.

Copy link
Contributor

@eeeeevon13 eeeeevon13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@keoshi
Copy link
Contributor Author

keoshi commented Oct 11, 2021

@rcanepa I believe that change was made already: https://github.com/Automattic/wp-calypso/pull/56937/files#diff-e3c5865394c7fd90760e374a2d5b9ab749bc1534e13b535a5a01304b5af417e6R54 — I cannot find other instances of that string, is there any other place I should be looking at?

@rcanepa
Copy link
Contributor

rcanepa commented Oct 11, 2021

@rcanepa I believe that change was made already: https://github.com/Automattic/wp-calypso/pull/56937/files#diff-e3c5865394c7fd90760e374a2d5b9ab749bc1534e13b535a5a01304b5af417e6R54 — I cannot find other instances of that string, is there any other place I should be looking at?

Oh, I can't believe I missed that. You're right. This PR handles both UIs: the one for users who get their subscriptions automatically provisioned and the one for those who don't.

🚢

@keoshi keoshi merged commit 9e9ad08 into trunk Oct 11, 2021
@keoshi keoshi deleted the update/jetpack-checkout-siteless-thank-you-copy branch October 11, 2021 15:55
@github-actions github-actions bot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Design Input Requested Label automatically added to PRs where design feedback is requested labels Oct 11, 2021
@a8ci18n
Copy link

a8ci18n commented Oct 11, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6761529

Thank you @keoshi for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 21, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants