Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update text on loading screen #57256

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Conversation

roo2
Copy link
Contributor

@roo2 roo2 commented Oct 22, 2021

Changes proposed in this Pull Request

Simply updates the text on the loading screen, and reduce the expected loading time for when HS is run. I may look at adding other improvements in future:

  • Change the messages on the loading screen if no design is selected.
  • Use specific times for each step to give a feeling of steps taking amounts of time

p1634769393106000-slack-C029SB8JT8S

Testing instructions

Go to the intent screen and select the build flow, select a theme such as twentytwenty which will have a long loading time. Observer that the text has been updated on the loading screen
/start/setup-site/intent?flags=signup/hero-flow&siteSlug=YOUR_SITE.wordpress.com
Related to #

@roo2 roo2 requested a review from p-jackson October 22, 2021 03:59
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 22, 2021
@github-actions
Copy link

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
signup        -21 B  (-0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

__( 'Securing your information' ),
__( 'Sprinkling some magic' ),
__( 'Securing your data' ),
__( 'Enabling encryption' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Enabling SSL encryption' ) ES Score: 8

@roo2 roo2 merged commit b981a64 into trunk Oct 25, 2021
@roo2 roo2 deleted the update/improve-signup-loading-page branch October 25, 2021 02:40
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 25, 2021
@a8ci18n
Copy link

a8ci18n commented Oct 25, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6898106

Hi @roo2, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Laying the foundations
  • Turning on the lights
  • Making it beautiful
  • Sprinkling some magic
  • Securing your data
  • Applying a shiny top coat

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Oct 28, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants