-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update text on loading screen #57256
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:commit-e64ab8cc204a36ac0a48e1861e0bc37374e558c4 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~14 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
__( 'Securing your information' ), | ||
__( 'Sprinkling some magic' ), | ||
__( 'Securing your data' ), | ||
__( 'Enabling encryption' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Enabling SSL encryption' )
ES Score: 8
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6898106 Hi @roo2, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Simply updates the text on the loading screen, and reduce the expected loading time for when HS is run. I may look at adding other improvements in future:
p1634769393106000-slack-C029SB8JT8S
Testing instructions
Go to the intent screen and select the build flow, select a theme such as twentytwenty which will have a long loading time. Observer that the text has been updated on the loading screen
/start/setup-site/intent?flags=signup/hero-flow&siteSlug=YOUR_SITE.wordpress.com
Related to #