-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default A records on user request #57972
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-19526 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~3 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~103 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
This PR modifies the release build for notifications To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-elI-p2 |
dea4220
to
dd7008b
Compare
dd5e93d
to
eeb6737
Compare
@@ -1,7 +1,6 @@ | |||
import { Button } from '@automattic/components'; | |||
import { useI18n } from '@wordpress/react-i18n'; | |||
import { domainManagementDnsAddRecord } from 'calypso/my-sites/domains/paths'; | |||
import './dns-breadcrumb-button.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is handled by the breadcrumb styles now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/my-sites/domains/domain-management/dns/dns-menu-options-button.tsx
Outdated
Show resolved
Hide resolved
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6978902 Hi @delputnam, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
* Set default A records on user request * dispatch prop types * Better types for promises * Styles are now handled by the breadcrumb component, so no need for these * WIP * re-add updateDns * Bug fixes * Bug fixes * Make update call for root records * Not using success/error methods in the DnsRecords component * Remove optional chaining operator for required prop
Changes proposed in this Pull Request
Testing instructions
Set non-default A and AAAA records on a domain.
You can also set the pointsToWpcom value for the test domain to
false
to make it easier to test.In the DNS menu, use the action button at the top of page and select the option to reset the default A records.
Make sure that you get the success message and that the page is re-rendered with the new records.
Also use the patch instructions to fake an error and make sure that the error message is shown and the rendered records are unchanged.
Also make sure that the deleted records and the added records are in the same changeset.